Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Footer Enhancement #4378

Merged
merged 3 commits into from
Jun 16, 2024
Merged

[Feature]: Footer Enhancement #4378

merged 3 commits into from
Jun 16, 2024

Conversation

ayush-848
Copy link
Contributor

PR Description 📜

I have added the footer links and newsletter button

Fixes #4273

Mark the task you have completed ✅

  • I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • I have added screenshot for website preview in assets/images
  • I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

image


Thank you soo much for contributing to our repository 💗

@kunjgit
Copy link
Owner

kunjgit commented Jun 9, 2024

Thank you @ayush-848 ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

@ayush-848
Copy link
Contributor Author

@kunjgit Please check this PR

ishita-43
ishita-43 reviewed Jun 11, 2024
View reviewed changes
index.html
</div>

<!-- Subscribe to Newsletter Section -->
<div class="newsletter">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not fully functional right its only frontend

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry @ishita-43 I didn't get you

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how the entries enter by the user eg email in newsletter will be reached to the admin

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ishita-43 Yes I only did the frontend intentionally. While creating the issue I mentioned that I will design the footer part.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ishita-43 won't this PR get merged. Its been days

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

working on this!

ishita-43
ishita-43 approved these changes Jun 16, 2024
View reviewed changes
Copy link
Collaborator

@ishita-43 ishita-43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!!

@ishita-43 ishita-43 added level1 Documentation and small bug fixes in gssoc Ready to merge 🥳 gssoc GSSoC24 program label labels Jun 16, 2024
@kunjgit kunjgit merged commit 69576c5 into kunjgit:main Jun 16, 2024
@kunjgit
Copy link
Owner

kunjgit commented Jun 16, 2024

Thank you @ayush-848 , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishita-43 ishita-43 ishita-43 approved these changes

Assignees
No one assigned
Labels
gssoc GSSoC24 program label level1 Documentation and small bug fixes in gssoc Ready to merge 🥳
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement]: To design the footer properly
3 participants
@ayush-848 @kunjgit @ishita-43