Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noughts And Crosses #4376

Merged
merged 24 commits into from
Jun 15, 2024
Merged

Noughts And Crosses #4376

merged 24 commits into from
Jun 15, 2024

Conversation

meetarora10
Copy link
Contributor

PR Description 📜

Noughts and crosses is a game between two players, O and X, who alternate in marking the spaces in a 3×3 board. A player wins by getting three of their own marks in a horizontal, vertical or diagonal row. I have used technologies such as HTML,CSS and JavaScript.
Fixes #4375


Mark the task you have completed ✅

  • I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • I have added screenshot for website preview in assets/images
  • I have added entries for my game in main README.md
  • I have added README.md in my folder
  • I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

Screenshot (467)



Thank you soo much for contributing to our repository 💗

@kunjgit
Copy link
Owner

kunjgit commented Jun 9, 2024

Thank you @meetarora10 ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

Copy link
Owner

@kunjgit kunjgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @meetarora10,
You need to make the following changes:

  • Please add a README.md file inside the newly created folder.
  • Please modify the main README.md file.
  • Please add an image to the assets/images directory.

Hoping that you will make those changes soon 🚀

Copy link
Owner

@kunjgit kunjgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @meetarora10,
You need to make the following changes:

  • Please add a README.md file inside the newly created folder.
  • Please modify the main README.md file.
  • Please add an image to the assets/images directory.

Hoping that you will make those changes soon 🚀

Copy link
Owner

@kunjgit kunjgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @meetarora10,
You need to make the following changes:

  • Please modify the main README.md file.

Hoping that you will make those changes soon 🚀

Copy link
Owner

@kunjgit kunjgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @meetarora10,
You need to make the following changes:

  • Please modify the main README.md file.

Hoping that you will make those changes soon 🚀

@meetarora10
Copy link
Contributor Author

@kunjgit I have made the changes.

@meetarora10 meetarora10 requested a review from kunjgit June 9, 2024 14:11
@meetarora10
Copy link
Contributor Author

@kunjgit I have resolved the merge conflicts please review once.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add your game entry around line number 325 refer other entries for format

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@meetarora10 meetarora10 requested a review from ishita-43 June 12, 2024 06:41
@ishita-43 ishita-43 added level2 Enhancement in gssoc Ready to merge 🥳 gssoc GSSoC24 program label labels Jun 13, 2024
Copy link
Collaborator

@ishita-43 ishita-43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!!

@kunjgit kunjgit merged commit 9480047 into kunjgit:main Jun 15, 2024
@kunjgit
Copy link
Owner

kunjgit commented Jun 15, 2024

Thank you @meetarora10 , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀

@kunjgit kunjgit mentioned this pull request Jun 15, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes Requested ⚒️ Changes have to be done gssoc GSSoC24 program label level2 Enhancement in gssoc Pending ⏱️ Ready to merge 🥳
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New game]: Noughts And Crosses
3 participants