Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Game : Ganesh QR Maker #4369

Merged
merged 11 commits into from
Jun 20, 2024
Merged

New Game : Ganesh QR Maker #4369

merged 11 commits into from
Jun 20, 2024

Conversation

codewithganeshhh
Copy link
Contributor

PR Description 📜

Please include summary related to the issue you have fixed and describe your PR in brief over here by specifying the issue number on which you were working below:

It was used Latest Technology
A simple web application which will generate a QR Code.

Fixes #4367


Mark the task you have completed ✅

  • [ ✅] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • [ ✅] I have performed a self-review of my own code or work.
  • [ ✅] I have commented my code, particularly in hard-to-understand areas.
  • [✅ ] My changes generates no new warnings.
  • [ ✅] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • [ ✅] I have added screenshot for website preview in assets/images
  • [ ✅] I have added entries for my game in main README.md
  • [✅ ] I have added README.md in my folder
  • [ ✅] I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

QR CODE Generator



Thank you soo much for contributing to our repository 💗

@kunjgit
Copy link
Owner

kunjgit commented Jun 9, 2024

Thank you @codewithganeshhh ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

Copy link
Owner

@kunjgit kunjgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @codewithganeshhh,
You need to make the following changes:

  • Please add an image to the assets/images directory.

Hoping that you will make those changes soon 🚀

@codewithganeshhh codewithganeshhh requested a review from kunjgit June 9, 2024 06:13
@codewithganeshhh
Copy link
Contributor Author

All Resolve @kunjgit @Ishan-77 check this

@codewithganeshhh
Copy link
Contributor Author

Dear @kunjgit Please check and merge

@codewithganeshhh
Copy link
Contributor Author

dear @kunjgit please check asap

@codewithganeshhh
Copy link
Contributor Author

@kunjgit @ishita-43 please review and merge

Copy link
Collaborator

@ishita-43 ishita-43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!!

@ishita-43 ishita-43 added level2 Enhancement in gssoc Ready to merge 🥳 gssoc GSSoC24 program label labels Jun 19, 2024
@kunjgit kunjgit merged commit 2b4aa63 into kunjgit:main Jun 20, 2024
@kunjgit
Copy link
Owner

kunjgit commented Jun 20, 2024

Thank you @codewithganeshhh , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes Requested ⚒️ Changes have to be done gssoc GSSoC24 program label level2 Enhancement in gssoc Pending ⏱️ Ready to merge 🥳
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New game]: Ganesh QR Maker
3 participants