Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Tetris Game #4361

Merged
merged 6 commits into from
Jun 14, 2024
Merged

Added Tetris Game #4361

merged 6 commits into from
Jun 14, 2024

Conversation

muskan42
Copy link
Contributor

@muskan42 muskan42 commented Jun 8, 2024

PR Description 📜

Added Tetris Game
Fixes #4312

Mark the task you have completed ✅

  • [ x ] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • [ x ] I have performed a self-review of my own code or work.
  • [ x ] I have commented my code, particularly in hard-to-understand areas.
  • [ x ] My changes generates no new warnings.
  • [ x ] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • [ x ] I have added screenshot for website preview in assets/images
  • [ x ] I have added entries for my game in main README.md
  • [ x ] I have added README.md in my folder
  • [ x ] I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

Screenshot 2024-06-07 123816


Thank you soo much for contributing to our repository 💗

@kunjgit
Copy link
Owner

kunjgit commented Jun 8, 2024

Thank you @muskan42 ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

kunjgit
kunjgit requested changes Jun 8, 2024
View reviewed changes
Copy link
Owner

@kunjgit kunjgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @muskan42,
You need to make the following changes:

  • Please add a README.md file inside the newly created folder.
  • Please modify the main README.md file.
  • Please add an image to the assets/images directory.

Hoping that you will make those changes soon 🚀

@muskan42
Copy link
Contributor Author

muskan42 commented Jun 8, 2024

Hello @muskan42, You need to make the following changes:

  • Please add a README.md file inside the newly created folder.
  • Please modify the main README.md file.
  • Please add an image to the assets/images directory.

Hoping that you will make those changes soon 🚀

It's already done

@muskan42 muskan42 requested a review from kunjgit June 8, 2024 21:35
kunjgit
kunjgit requested changes Jun 9, 2024
View reviewed changes
Copy link
Owner

@kunjgit kunjgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @muskan42,
You need to make the following changes:

  • Please add a README.md file inside the newly created folder.
  • Please modify the main README.md file.
  • Please add an image to the assets/images directory.

Hoping that you will make those changes soon 🚀

ishita-43
ishita-43 requested changes Jun 9, 2024
View reviewed changes
Copy link
Collaborator

@ishita-43 ishita-43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to make this change in your Pull request

assets/images/black.png Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow contribution guideline while naming the images in asset folder refer contribution.md

Copy link
Contributor Author

@muskan42 muskan42 Jun 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to rename them but the preload function I used in the js file is creating an issue when the names are altered.
Also please let me know the issue with the Readme file that is mentioned above.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be because you didnt name the readme file in capital letters so bot was unable to detect the same file in your game

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want you can change that to capitals

Copy link
Contributor Author

@muskan42 muskan42 Jun 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done but still asking for the same changes

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not a problem it is just asking approval from our side your job is done

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not a problem it is just asking approval from our side your job is done

okay

@ishita-43
Copy link
Collaborator

@muskan42 we are reviewing the code it may take some time.
Till than thank you for your patience.

kunjgit
kunjgit requested changes Jun 9, 2024
View reviewed changes
Copy link
Owner

@kunjgit kunjgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @muskan42,
You need to make the following changes:

  • Please add a README.md file inside the newly created folder.
  • Please modify the main README.md file.
  • Please add an image to the assets/images directory.

Hoping that you will make those changes soon 🚀

ishita-43
ishita-43 requested changes Jun 11, 2024
View reviewed changes
README.md Outdated
@@ -339,7 +339,7 @@ This repository also provides one such platforms where contributers come over an
| [Rapid_click_frenzy](https://github.com/kunjgit/GameZone/tree/main/Games/Rapid_click_frenzy)
|[Penguins Can't Fly](https://github.com/Will2Jacks/GameZoneForked/tree/Task/Games/Penguins_Can't_Fly)|
| [Taash_Game](https://github.com/kunjgit/GameZone/tree/main/Games/Taash_Game)|

| [Tetris Game](https://github.com/kunjgit/GameZone/tree/main/Games/tetris_game)|
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

place your game entry 10places above it is giving merge conflicts.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

ishita-43
ishita-43 approved these changes Jun 13, 2024
View reviewed changes
Copy link
Collaborator

@ishita-43 ishita-43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!!

@ishita-43 ishita-43 added Ready to merge 🥳 level3 Adding new features gssoc GSSoC24 program label labels Jun 13, 2024
@kunjgit kunjgit merged commit 10184ba into kunjgit:main Jun 14, 2024
@kunjgit
Copy link
Owner

kunjgit commented Jun 14, 2024

Thank you @muskan42 , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kunjgit kunjgit kunjgit requested changes

@ishita-43 ishita-43 ishita-43 approved these changes

Assignees
No one assigned
Labels
Changes Requested ⚒️ Changes have to be done gssoc GSSoC24 program label level3 Adding new features Pending ⏱️ Ready to merge 🥳
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[New game]: Tetris
3 participants
@muskan42 @kunjgit @ishita-43