Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Tetris Game #4318

Closed
wants to merge 2 commits into from
Closed

Added Tetris Game #4318

wants to merge 2 commits into from

Conversation

muskan42
Copy link
Contributor

@muskan42 muskan42 commented Jun 7, 2024

PR Description 📜

Added Tetris Game
Fixes #4312


Mark the task you have completed ✅

  • [ x ] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • [ x ] I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • [ x ] My changes generates no new warnings.
  • I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • [ x ] I have added screenshot for website preview in assets/images
  • [ x ] I have added entries for my game in main README.md
  • [ x ] I have added README.md in my folder
  • I have added working video of the game in README.md (optional)
  • [ x ] I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

image



Thank you soo much for contributing to our repository 💗

@kunjgit
Copy link
Owner

kunjgit commented Jun 7, 2024

Thank you @muskan42 ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

Copy link
Owner

@kunjgit kunjgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @muskan42,
You need to make the following changes:

  • Please add a README.md file inside the newly created folder.
  • Please modify the main README.md file.
  • Please add an image to the assets/images directory.

Hoping that you will make those changes soon 🚀

Modified the Main Readme.
Copy link
Owner

@kunjgit kunjgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @muskan42,
You need to make the following changes:

  • Please add a README.md file inside the newly created folder.
  • Please modify the main README.md file.
  • Please add an image to the assets/images directory.

Hoping that you will make those changes soon 🚀

@muskan42
Copy link
Contributor Author

muskan42 commented Jun 7, 2024

@kunjgit I tried several times but the images of my game ain't working when put under the assets folder of the GameZone project but is correctly working on other projects. I have even cross-checked the paths multiple times yet it created an issue so I added the folder inside my game folder.

I request you to please allow the folder there. It won't create an issue with other parts of the project.

@muskan42
Copy link
Contributor Author

muskan42 commented Jun 7, 2024

Hello @muskan42, You need to make the following changes:

  • Please add a README.md file inside the newly created folder.
  • Please modify the main README.md file.
  • Please add an image to the assets/images directory.

Hoping that you will make those changes soon 🚀

@kunjgit I already did the changes you requested

@kunjgit kunjgit mentioned this pull request Jun 8, 2024
@muskan42 muskan42 closed this Jun 8, 2024
@kunjgit
Copy link
Owner

kunjgit commented Jun 8, 2024

Thank you @muskan42 , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New game]: Tetris
2 participants