Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

soccer game added #4286

Merged
merged 5 commits into from
Jun 10, 2024
Merged

soccer game added #4286

merged 5 commits into from
Jun 10, 2024

Conversation

bhumika-1127
Copy link
Contributor

@kunjgit I have added a soccer game wrt issue #4198.Kindly review the PR.

Screenshot 2024-06-06 154128

@kunjgit
Copy link
Owner

kunjgit commented Jun 6, 2024

Thank you @bhumika-1127 ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

@bhumika-1127
Copy link
Contributor Author

/assign

@bhumika-1127
Copy link
Contributor Author

@kunjgit Kindly review the pr.

ishita-43
ishita-43 requested changes Jun 9, 2024
View reviewed changes
Copy link
Collaborator

@ishita-43 ishita-43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make changes soon!!

assets/js/gamesData.json Outdated
@@ -2102,11 +2102,22 @@
"gameTitle": "Guess_The_Song",
"gameUrl": "Guess_The_Song",
"thumbnailUrl": "Guess_The_Song.png"
},"421":{"gameTitle": "Pen_Pointer_Fight",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this one if not intended!!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep your project entry only

assets/js/gamesData.json Outdated
"gameTitle": "MathQuiz",
"gameUrl": "MathQuiz",
"thumbnailUrl": "MathQuiz.png"
},"423":{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after removing other your entry should be below 417 as 423

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you added 421,422 also by yourself!!

assets/js/index.js Outdated Show resolved Hide resolved
ishita-43
ishita-43 reviewed Jun 9, 2024
View reviewed changes
assets/js/gamesData.json Show resolved Hide resolved
assets/js/gamesData.json Outdated Show resolved Hide resolved
assets/js/gamesData.json Outdated Show resolved Hide resolved
assets/js/gamesData.json Outdated Show resolved Hide resolved
ishita-43
ishita-43 approved these changes Jun 9, 2024
View reviewed changes
Copy link
Collaborator

@ishita-43 ishita-43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!!

@ishita-43 ishita-43 added Ready to merge 🥳 level3 Adding new features gssoc GSSoC24 program label labels Jun 9, 2024
@kunjgit kunjgit merged commit 0d81e56 into kunjgit:main Jun 10, 2024
1 check passed
@kunjgit
Copy link
Owner

kunjgit commented Jun 10, 2024

Thank you @bhumika-1127 , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishita-43 ishita-43 ishita-43 approved these changes

Assignees

@bhumika-1127 bhumika-1127

Labels
gssoc GSSoC24 program label level3 Adding new features Pending ⏱️ Ready to merge 🥳
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bhumika-1127 @kunjgit @ishita-43