Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch the ball #4264

Merged
merged 6 commits into from
Jun 16, 2024
Merged

Catch the ball #4264

merged 6 commits into from
Jun 16, 2024

Conversation

shruti110503
Copy link
Contributor

PR Description 📜

Created the game catch the ball successfully.
Fixes #4124

Mark the task you have completed ✅

  • [x ] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • [ x] I have performed a self-review of my own code or work.
  • [x ] I have commented my code, particularly in hard-to-understand areas.
  • [ x] My changes generates no new warnings.
  • [x ] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • [x ] I have added screenshot for website preview in assets/images
  • [x ] I have added entries for my game in main README.md
  • [ x] I have added README.md in my folder
  • [ x] I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

catch-the-ball


Thank you soo much for contributing to our repository 💗

@kunjgit
Copy link
Owner

kunjgit commented Jun 5, 2024

Thank you @shruti110503 ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

ishita-43
ishita-43 requested changes Jun 9, 2024
View reviewed changes
README.md Outdated
@@ -301,6 +301,9 @@ This repository also provides one such platforms where contributers come over an
| [Pixel Painter](https://github.com/kunjgit/GameZone/tree/main/Games/pixel_painter) |
| [Guess_The_Song](https://github.com/kunjgit/GameZone/tree/main/Games/Guess_The_Song) |
| [NewsJunction](https://github.com/kunjgit/GameZone/tree/main/Games/NewsJunction) |


=======
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this line

README.md Outdated
@@ -322,6 +325,7 @@ This repository also provides one such platforms where contributers come over an
| [Tic-Tac-Toe Game](https://github.com/kunjgit/GameZone/tree/main/Games/Tic-Tac-Toe) |
| [Rapid_click_frenzy](https://github.com/kunjgit/GameZone/tree/main/Games/Rapid_click_frenzy)

| [Catch_The_Ball] (Games\Catch_The_Ball) |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enter your game properly
refer other entries

@shruti110503
Copy link
Contributor Author

@ishita-43 i have made the changes. Please review it.

ishita-43
ishita-43 requested changes Jun 11, 2024
View reviewed changes
README.md Outdated
@@ -322,6 +322,7 @@ This repository also provides one such platforms where contributers come over an
| [Tic-Tac-Toe Game](https://github.com/kunjgit/GameZone/tree/main/Games/Tic-Tac-Toe) |
| [Rapid_click_frenzy](https://github.com/kunjgit/GameZone/tree/main/Games/Rapid_click_frenzy)

| [Catch_The_Ball] (http://127.0.0.1:5501/Games/Catch_The_Ball/index.html) |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Place name of the game in the end instead!!
eg catch_the_ball should be same the folder name

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ishita-43 please check if it is alright now

ishita-43
ishita-43 approved these changes Jun 16, 2024
View reviewed changes
Copy link
Collaborator

@ishita-43 ishita-43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge!!

@ishita-43 ishita-43 added level2 Enhancement in gssoc Ready to merge 🥳 gssoc GSSoC24 program label labels Jun 16, 2024
@kunjgit kunjgit merged commit bd6097c into kunjgit:main Jun 16, 2024
@kunjgit
Copy link
Owner

kunjgit commented Jun 16, 2024

Thank you @shruti110503 , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishita-43 ishita-43 ishita-43 approved these changes

Assignees
No one assigned
Labels
gssoc GSSoC24 program label level2 Enhancement in gssoc Pending ⏱️ Ready to merge 🥳
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[New game]: Catch The ball
3 participants
@shruti110503 @kunjgit @ishita-43