Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beyblade Game Enhanced : Added many features, Nav Bar, a note on How to Play and many more. #4232

Closed
wants to merge 6 commits into from

Conversation

KomalMaurya
Copy link
Contributor

PR Description 📜

Please include summary related to the issue you have fixed and describe your PR in brief over here by specifying the issue number on which you were working below :

  1. I added Nav Bar in which I added logo of Beyblade Burst and changed background too.
  2. I added a button on "How to Play?" the game as it was confusing earlier.
  3. I added "Play Button" to start the game.
  4. I added pictures of beyblades and Bladers.
  5. I created a 3D model of Beyblade Stadium.
  6. I added animations of running beyblades and spinning too.

Fixes #4080


Mark the task you have completed ✅

  • [✅ ] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • [✅ ] I have performed a self-review of my own code or work.
  • [✅ ] I have commented my code, particularly in hard-to-understand areas.
  • [✅ ] My changes generates no new warnings.
  • [✅ ] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • [✅ ] I have added screenshot for website preview in assets/images
  • [✅ ] I have added entries for my game in main README.md
  • [✅ ] I have added README.md in my folder
  • [✅ ] I have added working video of the game in README.md (optional)
  • [✅ ] I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

Webpage



Thank you soo much for contributing to our repository 💗

@kunjgit
Copy link
Owner

kunjgit commented Jun 5, 2024

Thank you @KomalMaurya ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

Games/Beyblade/README.md Show resolved Hide resolved
Copy link
Collaborator

@ishita-43 ishita-43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope you will make changes soon if this seems lot of work for you can instead close this pr and create new one

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you dont need to change the files of the repo other than readme file instead create your own separate files for the code eg index.html inside your game folder only same for script and style file also make sure to include image of the game into the asset folder of the main repo follow naming convention of contribution.md while naming image for that

@KomalMaurya KomalMaurya closed this Jul 9, 2024
@KomalMaurya KomalMaurya deleted the Beyblade branch July 9, 2024 06:41
@kunjgit
Copy link
Owner

kunjgit commented Jul 9, 2024

Thank you @KomalMaurya , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Making Beyblade Game interactive
3 participants