Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing theme toggle #4204

Merged
merged 4 commits into from
Jul 17, 2024
Merged

Fixing theme toggle #4204

merged 4 commits into from
Jul 17, 2024

Conversation

Jasleen1210
Copy link
Contributor

The issue with the inversion of game images during light theme has been fixed. Only the game images are unaffected by the toggle and the font footer changes remain same as original. Also edited gamesData.json such that the games are in order and closed a bracket that was accidentally left open and causing error in the site.

PR Description 📜

Fixes #4148


Mark the task you have completed ✅

  • I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • I have added screenshot for website preview in assets/images
  • I have added entries for my game in main README.md
  • I have added README.md in my folder
  • I have added working video of the game in README.md (optional)
  • I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

game zone

Thank you soo much for contributing to our repository 💗

The issue with the inversion of game images during light theme has been fixed. Only the game images are unaffected by the toggle and the font footer changes remain same as original
@kunjgit
Copy link
Owner

kunjgit commented Jun 4, 2024

Thank you @Jasleen1210 ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

@ishita-43
Copy link
Collaborator

Please resolve merge conflicts

@Jasleen1210
Copy link
Contributor Author

Done! @ishita-43

assets/js/gamesData.json Show resolved Hide resolved
assets/js/gamesData.json Outdated Show resolved Hide resolved
Copy link
Collaborator

@ishita-43 ishita-43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge

@ishita-43 ishita-43 added Ready to merge 🥳 gssoc GSSoC24 program label labels Jul 17, 2024
@kunjgit kunjgit merged commit 34b91a3 into kunjgit:main Jul 17, 2024
@kunjgit
Copy link
Owner

kunjgit commented Jul 17, 2024

Thank you @Jasleen1210 , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc GSSoC24 program label Ready to merge 🥳
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Fixing the light mode toggle
3 participants