Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added a new game #4196

Merged
merged 11 commits into from
Jun 16, 2024
Merged

Added a new game #4196

merged 11 commits into from
Jun 16, 2024

Conversation

codewithishu
Copy link
Contributor

fixes #4194

  • I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • I have added screenshot for website preview in assets/images
  • I have added entries for my game in main README.md
  • I have added README.md in my folder
  • I have added working video of the game in README.md (optional)
  • I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

Screenshot 2024-06-04 004406

@kunjgit
Copy link
Owner

kunjgit commented Jun 3, 2024

Thank you @codewithishu ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

@codewithishu
Copy link
Contributor Author

Can you merge it

ishita-43
ishita-43 requested changes Jun 9, 2024
View reviewed changes
Copy link
Collaborator

@ishita-43 ishita-43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do same for all the images used in assests folder

assets/images/og-image (1).png Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename the images in assets folder according to the contribution guidelines

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have renamed it

@codewithishu codewithishu reopened this Jun 9, 2024
@kunjgit
Copy link
Owner

kunjgit commented Jun 9, 2024

Thank you @codewithishu , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀

@codewithishu
Copy link
Contributor Author

do same for all the images used in assests folder

I have done it

@codewithishu
Copy link
Contributor Author

@kunjgit please merge it

@codewithishu codewithishu requested a review from ishita-43 June 9, 2024 19:48
ishita-43
ishita-43 requested changes Jun 9, 2024
View reviewed changes
assets/images/og-image.png Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this if not needed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

ishita-43
ishita-43 requested changes Jun 9, 2024
View reviewed changes
Games/Wordling/_config.yml Show resolved Hide resolved
Games/Wordling/dictionary.js
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also empty remove!!

ishita-43
ishita-43 reviewed Jun 9, 2024
View reviewed changes
Games/Wordling/index.js
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

empty !! remove this if not needed

Games/Wordling/package.json
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty remove this if not needed!!

Games/Wordling/style.css
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this if not needed

@codewithishu codewithishu requested a review from ishita-43 June 9, 2024 20:29
@ishita-43
Copy link
Collaborator

Please try to resolve merge conflicts

@codewithishu
Copy link
Contributor Author

@kunjgit please merge it

@ishita-43 ishita-43 added level2 Enhancement in gssoc Ready to merge 🥳 gssoc GSSoC24 program label labels Jun 16, 2024
ishita-43
ishita-43 approved these changes Jun 16, 2024
View reviewed changes
Copy link
Collaborator

@ishita-43 ishita-43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to go!

@kunjgit kunjgit merged commit c854ce7 into kunjgit:main Jun 16, 2024
@kunjgit
Copy link
Owner

kunjgit commented Jun 16, 2024

Thank you @codewithishu , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishita-43 ishita-43 ishita-43 approved these changes

Assignees
No one assigned
Labels
gssoc GSSoC24 program label level2 Enhancement in gssoc Pending ⏱️ Ready to merge 🥳
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[New game]: Wordling
3 participants
@codewithishu @kunjgit @ishita-43