Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new game added #4157

Merged
merged 6 commits into from
Jul 26, 2024
Merged

new game added #4157

merged 6 commits into from
Jul 26, 2024

Conversation

parthshah02
Copy link
Contributor

@parthshah02 parthshah02 commented Jun 3, 2024 •
edited
Loading

PR Description 📜

Added new game Detona -Ralph

Fixes #4156

  • I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • I have added screenshot for website preview in assets/images
  • I have added entries for my game in main README.md
  • I have added README.md in my folder
  • I have added working video of the game in README.md (optional)
  • I have specified the respective issue number for which I have requested the new game.

Thank you soo much for contributing to our repository 💗

@kunjgit
Copy link
Owner

kunjgit commented Jun 3, 2024

Thank you @Parth20GitHub ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

kunjgit
kunjgit requested changes Jun 3, 2024
View reviewed changes
Copy link
Owner

@kunjgit kunjgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Parth20GitHub,
You need to make the following changes:

  • Please create a new folder inside the "Games" folder.
  • Please add a README.md file inside the newly created folder.
  • Please modify the main README.md file.
  • Please add an image to the assets/images directory.

Hoping that you will make those changes soon 🚀

@parthshah02
Copy link
Contributor Author

done

@parthshah02 parthshah02 requested a review from kunjgit June 6, 2024 19:02
@ishita-43
Copy link
Collaborator

Please make sure your image is visible in Pr and your game is updated in main Readme.md file

ishita-43
ishita-43 approved these changes Jul 26, 2024
View reviewed changes
Copy link
Collaborator

@ishita-43 ishita-43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go

@ishita-43 ishita-43 added Ready to merge 🥳 level3 Adding new features gssoc GSSoC24 program label and removed Changes Requested ⚒️ Changes have to be done labels Jul 26, 2024
@kunjgit kunjgit merged commit 5bb8016 into kunjgit:main Jul 26, 2024
@kunjgit
Copy link
Owner

kunjgit commented Jul 26, 2024

Thank you @Parth20GitHub , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kunjgit kunjgit kunjgit approved these changes

@ishita-43 ishita-43 ishita-43 approved these changes

Assignees
No one assigned
Labels
gssoc GSSoC24 program label level3 Adding new features Pending ⏱️ Ready to merge 🥳
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[New game]: Detona-Ralph
3 participants
@parthshah02 @kunjgit @ishita-43