Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fidget spinner #4119 #4142

Merged
merged 15 commits into from
Jun 22, 2024
Merged

Fidget spinner #4119 #4142

merged 15 commits into from
Jun 22, 2024

Conversation

nisargaa20
Copy link
Contributor

@nisargaa20 nisargaa20 commented Jun 3, 2024

PR Description 📜

Please include summary related to the issue you have fixed and describe your PR in brief over here by specifying the issue number on which you were working below
Fixes # <your_issue_number>

Fidget Spinner is an interactive online simulation of a physical fidget spinner. This digital version allows users to experience the satisfying and stress-relieving sensation of spinning a fidget spinner directly from their browser.

Interactive Spinning: Users can spin the fidget spinner by dragging the mouse across the screen.
Speed Display: The current speed of the spinner is displayed, giving users real-time feedback.
Custom Speed Setting: Users can set a custom speed for the fidget spinner, allowing for a personalized experience.
Automatic Spin: For those who prefer not to drag their mouse, a button is available to automatically spin the fidget spinner.
How to Play? 🕹️
Drag to Spin: Click and drag the mouse across the spinner to make it spin. The faster you drag, the faster the spinner will rotate.
View Speed: Watch the speedometer to see how fast the spinner is going.
Set Custom Speed: Use the input box to set a custom speed for the spinner.
Automatic Spin: Click the "Spin" button to make the spinner spin without dragging.

Fixed #4119


Mark the task you have completed ✅

  • I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • I have added screenshot for website preview in assets/images
  • I have added entries for my game in main README.md
  • I have added README.md in my folder
  • I have added working video of the game in README.md (optional)
  • I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

Uploading Fidget.png…



Thank you soo much for contributing to our repository 💗

@kunjgit
Copy link
Owner

kunjgit commented Jun 3, 2024

Thank you @nisargaa20 ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

@nisargaa20
Copy link
Contributor Author

@kunjgit Kindly review it sooner as it getting conflicts

@nisargaa20
Copy link
Contributor Author

@kunjgit kindly add labels

@nisargaa20
Copy link
Contributor Author

/assign

@nisargaa20
Copy link
Contributor Author

@kunjgit kindly add labels and review it . It has been 4 days I need to raise new issue

@nisargaa20
Copy link
Contributor Author

@ishita-43 Kindly check it out the PR and add labels

@nisargaa20
Copy link
Contributor Author

@kunjgit Its been a week kindly check it out ( conflicting is occuring)

Copy link
Collaborator

@ishita-43 ishita-43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make the desired changes!!

README.md Outdated
|[Carrom Board Game](https://github.com/kunjgit/GameZone/tree/main/Games/carrom)|
| [Number_Recall_Game](https://github.com/kunjgit/GameZone/tree/main/Games/Number_Recall_Game) |

| [Hit_the_hamster] (https://github.com/kunjgit/GameZone/tree/main/Games/Hit_the_hamster) |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete this duplicate entry from here



}
,"417":{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove all these entry and place your below each entry with no 417
or arrange the entry in the order
417
409
418
410
and so on at the bottom of file

@nisargaa20
Copy link
Contributor Author

@ishita-43 done check it out

@@ -2112,43 +2112,43 @@
"gameTitle": "Pen_Pointer_Fight",
"gameUrl": "PenPointerFight",
"thumbnailUrl": "PenPointerFight.png"
},"418":{
},"409":{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change as 418



},
"418":{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

409

}
},"408":{

},"417":{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

410

"gameTitle": "Soccer",
"gameUrl": "Soccer",
"thumbnailUrl": "Soccer"
},
"409":{"gameTitle": "Pen_Pointer_Fight",
"418":{"gameTitle": "Pen_Pointer_Fight",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

411



},"417":{
},"410":{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

419

"gameTitle": "Brick Buster",
"gameUrl": "Brick Buster",
"thumbnailUrl": "Brick.png"
},
"417":{
"409":{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

420

assets/js/gamesData.json Outdated Show resolved Hide resolved
@nisargaa20
Copy link
Contributor Author

@ishita-43 I got confused while doing check it out if its correct

@ishita-43
Copy link
Collaborator

@ishita-43 I got confused while doing check it out if its correct

ok you need to make changes in such a way that the number increase alternatingly
eg if you ha 407 416 these two entries in the end then make increament alternatinly eg first increase first number than second number so for above examolle series would be
407 416 than
408 417 409 418 410 and keep this increasing till all entries get nubered did you get this!!

@nisargaa20
Copy link
Contributor Author

@ishita-43 Thank you got it now . I have made the changes check it out

@ishita-43
Copy link
Collaborator

ishita-43 commented Jun 20, 2024

Merge conflicts are arising please do one think sync your json and readme file and then add again add your game there and then upload them here!! after this we will merge your PR.

@nisargaa20
Copy link
Contributor Author

@ishita-43 kindly merge it soon or else again there will be conflict if u merge others PR

Copy link
Collaborator

@ishita-43 ishita-43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good!!

@ishita-43 ishita-43 added Ready to merge 🥳 level3 Adding new features gssoc GSSoC24 program label labels Jun 21, 2024
@nisargaa20
Copy link
Contributor Author

@ishita-43 Kindly merge it

@kunjgit kunjgit merged commit e5c0684 into kunjgit:main Jun 22, 2024
@kunjgit
Copy link
Owner

kunjgit commented Jun 22, 2024

Thank you @nisargaa20 , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc GSSoC24 program label level3 Adding new features Pending ⏱️ Ready to merge 🥳
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New game]: Fidget Spinner
3 participants