Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tic tac toe #4096

Merged
merged 5 commits into from
Jun 7, 2024
Merged

Tic tac toe #4096

merged 5 commits into from
Jun 7, 2024

Conversation

Apurv7777
Copy link
Contributor

PR Description 📜

Please include summary related to the issue you have fixed and describe your PR in brief over here by specifying the issue number on which you were working below
Fixes #4095

Mark the task you have completed ✅

  • I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • I have added screenshot for website preview in assets/images
  • I have added entries for my game in main README.md
  • I have added README.md in my folder
  • I have added working video of the game in README.md (optional)
  • I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

image


Thank you soo much for contributing to our repository 💗

@kunjgit
Copy link
Owner

kunjgit commented Jun 2, 2024

Thank you @Apurv7777 ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

@Apurv7777
Copy link
Contributor Author

Please merge, if no changes are required . @kunjgit

1 similar comment
@Apurv7777
Copy link
Contributor Author

Please merge, if no changes are required . @kunjgit

ishita-43
ishita-43 requested changes Jun 6, 2024
View reviewed changes
Copy link
Collaborator

@ishita-43 ishita-43 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to modify the main README.md file and add your game there.

@Apurv7777
Copy link
Contributor Author

Make sure to modify the main README.md file and add your game there.

As this is the update of the game, which is already added in README.md. Modification is not require, I guess. @ishita-43

@ishita-43 ishita-43 added level2 Enhancement in gssoc Ready to merge 🥳 gssoc GSSoC24 program label labels Jun 7, 2024
ishita-43
ishita-43 approved these changes Jun 7, 2024
View reviewed changes
Copy link
Collaborator

@ishita-43 ishita-43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!! 🎊

@kunjgit kunjgit merged commit f4b8f24 into kunjgit:main Jun 7, 2024
3 checks passed
@kunjgit
Copy link
Owner

kunjgit commented Jun 7, 2024

Thank you @Apurv7777 , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishita-43 ishita-43 ishita-43 approved these changes

Assignees
No one assigned
Labels
gssoc GSSoC24 program label level2 Enhancement in gssoc Ready to merge 🥳
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Tic Tac Toe Game
3 participants
@Apurv7777 @kunjgit @ishita-43