Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brain Card Game Added #4050

Closed
wants to merge 4 commits into from
Closed

Brain Card Game Added #4050

wants to merge 4 commits into from

Conversation

CodeXsubham
Copy link
Contributor

@CodeXsubham CodeXsubham commented Jun 1, 2024

PR Description 📜

Added Brain Card Game to Increase the ability to remember 🧠

Added #4023


Mark the task you have completed ✅

  • I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • I have added screenshot for website preview in assets/images
  • I have added entries for my game in main README.md
  • I have added README.md in my folder
  • I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

Screenshot 2024-06-01 145106



Thank you soo much for contributing to our repository 💗

@kunjgit
Copy link
Owner

kunjgit commented Jun 1, 2024

Thank you @CodeXsubham ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

Copy link
Owner

@kunjgit kunjgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @CodeXsubham,
You need to make the following changes:

  • Please add a README.md file inside the newly created folder.
  • Please modify the main README.md file.
  • Please add an image to the assets/images directory.

Hoping that you will make those changes soon 🚀

@CodeXsubham
Copy link
Contributor Author

Hey @kunjgit PA,
I have already added the readme file plus asset directory , but I dont know what to modify in main readme.md file

@CodeXsubham CodeXsubham requested a review from kunjgit June 1, 2024 10:13
@kunjgit kunjgit mentioned this pull request Jun 1, 2024
@CodeXsubham
Copy link
Contributor Author

@kunjgit Hey PA,
kindly Review it , I have added Readme file in the folder , Assets directory and but idk how to update the main readme file , Please merge as soon as possible so that I can work on next PR ,Thank You

@CodeXsubham
Copy link
Contributor Author

@kunjgit hey PA ,
kindly merge it , so that i can works on another PR

Copy link
Owner

@kunjgit kunjgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CodeXsubham make sure you are adding image and entry of your game in main readme!

@CodeXsubham
Copy link
Contributor Author

@kunjgit how to add game in the main readme file ...idk how to

@kunjgit
Copy link
Owner

kunjgit commented Jun 3, 2024

@CodeXsubham I would request you to have a look at merged pr under new game addition that can give you idea !
read documentation properly !

Copy link
Collaborator

@ishita-43 ishita-43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add your game image in asset folder of the gamezone
update readme.md file of the gamezone refer other entries for the format

@kunjgit
Copy link
Owner

kunjgit commented Jun 20, 2024

Thank you @CodeXsubham , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀

@CodeXsubham CodeXsubham reopened this Jun 20, 2024
@kunjgit
Copy link
Owner

kunjgit commented Jun 20, 2024

Thank you @CodeXsubham , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants