Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add timer change and modern type result popup #3459

Closed
wants to merge 0 commits into from

Conversation

anisharma07
Copy link
Contributor

@anisharma07 anisharma07 commented May 19, 2024

PR Description πŸ“œ

Now user can change the duration for which they want to type..
UI of typing result was also changed and a modern UI was added.
Fixes #3457


Mark the task you have completed βœ…

  • I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • I have added screenshot for website preview in assets/images

Add your screenshots(Optional) πŸ“Έ

image
image

@kunjgit
Copy link
Owner

kunjgit commented May 19, 2024

Thank you @anisharma07 ,for creating the PR and contributing to our GameZone πŸ’—
Review team will review the PR and will reach out to you soon! πŸ˜‡
Make sure that you have marked all the tasks that you are done with βœ….
Thank you for your patience! πŸ˜€

Copy link
Owner

@kunjgit kunjgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kunjgit
Copy link
Owner

kunjgit commented May 19, 2024

@anisharma07 resolve the merge conflicts !

@anisharma07
Copy link
Contributor Author

conflicts resolved ... now you can merge the pull request

@anisharma07 anisharma07 requested a review from kunjgit May 19, 2024 13:14
@kunjgit
Copy link
Owner

kunjgit commented May 20, 2024

@anisharma07 it's not yet resolved !
there might be possible someone has even made changes after you have resolved make sure you are resolving after latest changes !

@anisharma07 anisharma07 force-pushed the master-typing/timer-bug branch from 10510e1 to cb4fdbf Compare May 20, 2024 16:24
@kunjgit
Copy link
Owner

kunjgit commented May 20, 2024

Thank you @anisharma07 , for your valuable time and contribution in our GameZone πŸ’—.
It’s our GameZone, so Let’s build this GameZone altogether !!🀝
Hoping to see you soon with another PR again πŸ˜‡
Wishing you all the best for your journey into Open SourceπŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Time control for master Typing and little UI Changes
2 participants