Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snake game page's color theme is changed to enhance the page's beauty #3370

Closed
wants to merge 6 commits into from

Conversation

Tasnuva12
Copy link
Contributor

@Tasnuva12 Tasnuva12 commented May 17, 2024

PR Description 📜

I have fixed the color theme of the page and changed the alignment of elements a little bit
Fixes #3366


Mark the task you have completed ✅

  • I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • I have added screenshot for website preview in assets/images
  • I have added entries for my game in main README.md
  • I have added README.md in my folder
  • I have added working video of the game in README.md (optional)
  • I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸



Thank you soo much for contributing to our repository 💗

Thank you soo much for contributing to our repository 💗

Tasnuva12 added 5 commits May 13, 2024 12:06
-renamed  the "Restart" button to "Reset" for clarity.
-ensured that the letter won't popup until the "Start" button is pressed.
-stopped the popup of the letter when the "Reset" button is pressed.
-enhance the functionality of both buttons to make it clear when the game starts and when it's reset.
-updated the hover and active effect of the button to change the color  during this events
I changed the color palette of the entire page to make it look good
@kunjgit
Copy link
Owner

kunjgit commented May 17, 2024

Thank you @Tasnuva12 ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

@Tasnuva12 Tasnuva12 marked this pull request as ready for review May 17, 2024 03:51
@kunjgit
Copy link
Owner

kunjgit commented May 17, 2024

@Tasnuva12 resolve the conflicts !

@Tasnuva12
Copy link
Contributor Author

Hello I changed the game's theme that's why it is showing conflict. should I not change the game's css file?
image

@kunjgit
Copy link
Owner

kunjgit commented May 19, 2024

@Tasnuva12 the issue is there is some changes after you and you are having changes on the same line that causes merge conflicts make sure you are learning it how to resolve that !

@kunjgit kunjgit closed this May 20, 2024
@kunjgit
Copy link
Owner

kunjgit commented May 20, 2024

Hey @Tasnuva12,
You can't work on a closed issue 👀!
Follow the proper guideline and make a new PR again 😀.
Happy Hacking 💗

@kunjgit
Copy link
Owner

kunjgit commented May 20, 2024

Thank you @Tasnuva12 , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Snake game page's design should be improved
2 participants