Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simon Game GUI fixed [Enhancement] #3206

Closed
wants to merge 1 commit into from
Closed

Conversation

T1rth1
Copy link
Contributor

@T1rth1 T1rth1 commented May 12, 2024

PR Description 📜

Simon Game Enhancement

  1. I enhanced the overall the GUI of the Simon Game and made it more user friendly
  2. Also i made it responsive for both divices.
  3. I fixed overall alignment of the buttons, level title and highest score title's alignement and their font-sizes, 4 squares and instrunction section's width for the smaller devices
    Fixes # 3145

Mark the task you have completed ✅

  • I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • I have added screenshot for website preview as below

Add your screenshots(Optional) 📸

Screenshot 2024-05-13 000617



Thank you soo much for contributing to our repository 💗

@kunjgit
Copy link
Owner

kunjgit commented May 12, 2024

Thank you @T1rth1 ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

@kunjgit
Copy link
Owner

kunjgit commented May 12, 2024

Hey @T1rth1,
Please make sure to link the relevant issue using the appropriate syntax, such as "#issueNumber" 👀.
Follow the proper guideline and make a new PR again 😀.
Happy Hacking 💗

@kunjgit kunjgit closed this May 12, 2024
@kunjgit
Copy link
Owner

kunjgit commented May 12, 2024

Thank you @T1rth1 , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀

@T1rth1 T1rth1 deleted the simonGame branch May 12, 2024 18:49
@T1rth1 T1rth1 restored the simonGame branch May 12, 2024 18:50
@T1rth1 T1rth1 deleted the simonGame branch May 12, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants