Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vinayak repeat #3175

Merged
merged 5 commits into from
May 13, 2024
Merged

Vinayak repeat #3175

merged 5 commits into from
May 13, 2024

Conversation

Vinayakkh
Copy link
Contributor

PR Description 📜

In Game when click on guess button it operate 2 times on a single integer which decrease the guess chance and 2 times same guess number is operate. I update js file as it runs a function 2 times when click on guess number.
Fixes #3171


Mark the task you have completed ✅

  • I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸



Thank you soo much for contributing to our repository 💗

@kunjgit
Copy link
Owner

kunjgit commented May 12, 2024

Thank you @Vinayakkh ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

Copy link
Owner

@kunjgit kunjgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kunjgit kunjgit added level1 Documentation and small bug fixes in gssoc gssoc GSSoC24 program label labels May 12, 2024
@kunjgit
Copy link
Owner

kunjgit commented May 12, 2024

@Vinayakkh please resolve the merge conflicts !

@kunjgit kunjgit added Pending ⏱️ and removed level1 Documentation and small bug fixes in gssoc labels May 12, 2024
@Vinayakkh
Copy link
Contributor Author

Resolved

@kunjgit kunjgit added level1 Documentation and small bug fixes in gssoc and removed Pending ⏱️ labels May 13, 2024
@kunjgit kunjgit merged commit 539bc97 into kunjgit:main May 13, 2024
1 check passed
@kunjgit
Copy link
Owner

kunjgit commented May 13, 2024

Thank you @Vinayakkh , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀

@Vinayakkh Vinayakkh deleted the vinayak_repeat branch May 16, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc GSSoC24 program label level1 Documentation and small bug fixes in gssoc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Guess_the_number take 2 guess with 1 input
2 participants