Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brought Simon Game in a single screen #3158

Merged
merged 2 commits into from
May 12, 2024
Merged

Conversation

BagchiShreya
Copy link
Contributor

PR Description 📜

Please include summary related to the issue you have fixed and describe your PR in brief over here by specifying the issue number on which you were working below

The issue was that the game was not in a single screen and the player had to scroll down to get the play button. Fixed this issue by making required adjustments and brought the entire game in a single screen. Now there is no need to scroll.

Fixes #3126


Mark the task you have completed ✅

  • I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • I have added screenshot for website preview in assets/images
  • I have added entries for my game in main README.md
  • I have added README.md in my folder
  • I have added working video of the game in README.md (optional)
  • I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

simon



Thank you soo much for contributing to our repository 💗

Made changes so that the entire game fits in a single screen (laptop/pc).
@kunjgit
Copy link
Owner

kunjgit commented May 12, 2024

Thank you @BagchiShreya ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

Copy link
Owner

@kunjgit kunjgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@kunjgit kunjgit merged commit f4dec1c into kunjgit:main May 12, 2024
3 checks passed
@kunjgit
Copy link
Owner

kunjgit commented May 12, 2024

Thank you @BagchiShreya , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀

@kunjgit kunjgit added level1 Documentation and small bug fixes in gssoc gssoc GSSoC24 program label labels May 12, 2024
@BagchiShreya
Copy link
Contributor Author

Thank you @BagchiShreya , for your valuable time and contribution in our GameZone 💗. It’s our GameZone, so Let’s build this GameZone altogether !!🤝 Hoping to see you soon with another PR again 😇 Wishing you all the best for your journey into Open Source🚀

Thank You

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc GSSoC24 program label level1 Documentation and small bug fixes in gssoc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simon_Game_Challenge[Enhancement]:
2 participants