Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bubble_Hit #3100 #3112

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Bubble_Hit #3100 #3112

wants to merge 6 commits into from

Conversation

prachi-kurmi
Copy link

PR Description 📜

In this PR, I added the new game "Bubble Hit". This game involves popping bubbles within a 60-second time limit to earn points. Players aim to match numbers displayed in a hit box located at the top left corner with bubbles on the screen. Each correct bubble popped earns points, and the game ends after 60 seconds.

Fixes #3098

Mark the task you have completed ✅

  • [ * ] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • [ * ] I have performed a self-review of my own code or work.
  • [ * ] My changes generates no new warnings.
  • [ * ] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • [ * ] I have added screenshot for website preview in assets/images
  • [ * ] I have added entries for my game in main README.md
  • [ * ] I have added README.md in my folder
  • [ * ] I have added working video of the game in README.md (optional)
  • [ * ] I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

Screenshot 2024-05-11 125555

Thank you soo much for contributing to our repository 💗

@kunjgit
Copy link
Owner

kunjgit commented May 11, 2024

Thank you @prachi-kurmi ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

@prachi-kurmi
Copy link
Author

@kunjgit , kindly review my PR

Copy link
Owner

@kunjgit kunjgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prachi-kurmi please follow guidelines and add your game in readme and your image in assets as specified !

@prachi-kurmi
Copy link
Author

@kunjgit I have made the changes you said please check it and thank you for your time

@kunjgit
Copy link
Owner

kunjgit commented May 15, 2024

@prachi-kurmi you have to add it in root directory so your game can be pushed in GameZone also you have to add your game entry in main README file !

@prachi-kurmi
Copy link
Author

@kunjgit Could you please explain what steps I need to take after pushing the game to the main branch, adding images to the assets folder, and providing the README.md file.

Should I include the live link to the game in the main README.md file?

@ishita-43
Copy link
Collaborator

Add your game entry in main Readme file of the gamezone folder for reference see other pr how they did it. You need to add link of your game in main file of the project @prachi-kurmi .

@ishita-43 ishita-43 added the Changes Requested ⚒️ Changes have to be done label Jun 6, 2024
@prachi-kurmi
Copy link
Author

hey @ishita-43 could you please tell me why am i getting this conflict?

@prachi-kurmi
Copy link
Author

@ishita-43 Could you please review it and tell me whether the changes i have made is correct or not.

Copy link
Collaborator

@ishita-43 ishita-43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PLEASE ADD YOUR GAME ENTRY In main readme.md file you will find this in same hierarchy where you find asset folder refer other entries for the format

Copy link
Collaborator

@ishita-43 ishita-43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PLEASE ADD YOUR GAME ENTRY In main readme.md file you will find this in same hierarchy where you find asset folder refer other entries for the format

@ishita-43
Copy link
Collaborator

@ishita-43 Could you please review it and tell me whether the changes i have made is correct or not.

You can refer other pr readme update to get idea how they are doing that if haaave question you can ask me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New game]: Bubble Hit #3100
3 participants