-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
working setup of flink via kuttl #285
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
apiVersion: v1 | ||
kind: Pod | ||
metadata: | ||
name: kudo-controller-manager-0 | ||
namespace: kudo-system | ||
status: | ||
phase: Running | ||
|
||
# confirms that kudo is running | ||
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
apiVersion: storage.k8s.io/v1 | ||
kind: StorageClass | ||
metadata: | ||
annotations: | ||
storageclass.kubernetes.io/is-default-class: "true" | ||
name: standard | ||
provisioner: rancher.io/local-path | ||
reclaimPolicy: Delete | ||
volumeBindingMode: WaitForFirstConsumer | ||
|
||
# default storage class for kind... it is an error if it exists |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
apiVersion: kuttl.dev/v1beta1 | ||
kind: TestStep | ||
commands: | ||
- command: kubectl delete storageclass standard | ||
- command: kubectl apply -f https://raw.githubusercontent.com/rancher/local-path-provisioner/master/deploy/local-path-storage.yaml | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is applying the same There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @kensipe I see this as an infra step. If we run these tests along with other tests present in this repository we might be changing the outcome of the tests. What about just using the storage class that is already present and which is being deleted? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yeah... these tests are great for setting up and running / verifying the flink demo... perhaps we shouldn't hook them into the infra... is there any suggestion? |
||
- command: kubectl annotate storageclass --overwrite local-path storageclass.kubernetes.io/is-default-class=true |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
apiVersion: kudo.dev/v1beta1 | ||
kind: OperatorVersion | ||
metadata: | ||
name: flink-0.2.1 | ||
spec: | ||
appVersion: 1.7.2 | ||
operator: | ||
kind: Operator | ||
name: flink | ||
--- | ||
apiVersion: kudo.dev/v1beta1 | ||
kind: OperatorVersion | ||
metadata: | ||
name: kafka-1.2.0 | ||
spec: | ||
appVersion: 2.4.0 | ||
operator: | ||
kind: Operator | ||
--- | ||
apiVersion: kudo.dev/v1beta1 | ||
kind: OperatorVersion | ||
metadata: | ||
name: zookeeper-0.3.0 | ||
spec: | ||
appVersion: 3.4.14 | ||
operator: | ||
kind: Operator |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
apiVersion: kuttl.dev/v1beta1 | ||
kind: TestStep | ||
commands: | ||
- command: kubectl kudo install zookeeper --operator-version=0.3.0 --skip-instance | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's use local packages here, i.e. relative paths instead of packages from the community repository. This will allow us to see if (local) changes to any of these operators break this test. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. perhaps these tests are different... and should be relocated or not hooked into the infra... this is under the "demo" folder and these teams are similar to our use of kuttl for MWT.. they setup a cluster with the flink demo. On the other hand... I could see value in having the demo checked on PRs to confirm it still works... hmm.. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. None of these steps are necessary once #279 is merged |
||
namespaced: true | ||
- command: kubectl kudo install kafka --operator-version=1.2.0 --skip-instance | ||
namespaced: true | ||
- command: kubectl kudo install flink --operator-version=0.2.1 --skip-instance | ||
namespaced: true |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
apiVersion: kuttl.dev/v1beta1 | ||
kind: TestAssert | ||
timeout: 600 | ||
--- | ||
apiVersion: kudo.dev/v1beta1 | ||
kind: Instance | ||
metadata: | ||
name: zk | ||
status: | ||
planStatus: | ||
deploy: | ||
status: COMPLETE | ||
|
||
# kubectl kudo plan status --instance zk |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
apiVersion: kuttl.dev/v1beta1 | ||
kind: TestStep | ||
commands: | ||
- command: kubectl kudo install ../../financial-fraud/demo-operator --instance flink-demo | ||
namespaced: true |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
apiVersion: kuttl.dev/v1beta1 | ||
kind: TestAssert | ||
timeout: 600 | ||
--- | ||
apiVersion: kudo.dev/v1beta1 | ||
kind: Instance | ||
metadata: | ||
name: kafka | ||
status: | ||
planStatus: | ||
deploy: | ||
status: COMPLETE | ||
|
||
# kubectl kudo plan status --instance kafka |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
apiVersion: kuttl.dev/v1beta1 | ||
kind: TestAssert | ||
timeout: 600 | ||
--- | ||
apiVersion: kudo.dev/v1beta1 | ||
kind: Instance | ||
metadata: | ||
name: flink | ||
status: | ||
planStatus: | ||
deploy: | ||
status: COMPLETE | ||
|
||
# kubectl kudo plan status --instance flink | ||
# this object does not exist until created by demo deploy plan |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
apiVersion: kuttl.dev/v1beta1 | ||
kind: TestAssert | ||
timeout: 600 | ||
--- | ||
apiVersion: kudo.dev/v1beta1 | ||
kind: Instance | ||
metadata: | ||
name: flink-demo | ||
status: | ||
planStatus: | ||
deploy: | ||
status: COMPLETE | ||
|
||
# similar to kubectl kudo plan status --instance flink-demo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is it necessary to check this here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fail fast and portability
frankly if kudo is running this is a quick sub second check... what are the concerns?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's not a pattern we should promote: this is something that is covered
beforeAll
tests (by usingkudo init --wait
) option. I guess you could see it as very defensive programming but frankly, this shouldn't be necessary