-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
creating cowsay kuttl tests #284
Open
kensipe
wants to merge
2
commits into
master
Choose a base branch
from
ken/cowsay-kuttl
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| apiVersion: v1 | ||
| kind: Pod | ||
| metadata: | ||
| name: kudo-controller-manager-0 | ||
| namespace: kudo-system | ||
| status: | ||
| phase: Running | ||
|
|
||
| # confirms that kudo is running | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| apiVersion: kudo.dev/v1beta1 | ||
| kind: Instance | ||
| metadata: | ||
| labels: | ||
| kudo.dev/operator: cowsay | ||
| name: cowsay-instance | ||
| namespace: default | ||
| status: | ||
| planStatus: | ||
| deploy: | ||
| name: deploy | ||
| phases: | ||
| - name: main | ||
| status: COMPLETE | ||
| steps: | ||
| - name: genfiles | ||
| status: COMPLETE | ||
| - name: app | ||
| status: COMPLETE | ||
| status: COMPLETE |
4 changes: 4 additions & 0 deletions
4
repository/cowsay/tests/cowsay-config-map/01-install-cowsay.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| apiVersion: kuttl.dev/v1beta1 | ||
| kind: TestStep | ||
| commands: | ||
| - command: kubectl kudo install ../../operator |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| apiVersion: v1 | ||
| kind: ConfigMap | ||
| metadata: | ||
| annotations: | ||
| kudo.dev/phase: main | ||
| kudo.dev/plan: deploy | ||
| kudo.dev/step: genfiles | ||
| labels: | ||
| heritage: kudo | ||
| kudo.dev/instance: cowsay-instance | ||
| kudo.dev/operator: cowsay | ||
| name: cowsayinstance.deploy.main.genfiles.genwww.indexhtml | ||
| namespace: default |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is it necessary to check this here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also thought that this PR removed this assertion in favor of
kudo init ... --waitThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it makes the test more portal IMO... yes we should have a kudo init --wait. This fails fast if that wasn't done.. and I see these tests as something we may point users to... that may run them...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean, we don't wait for KUDO this way for other operators tests today (because we already
kudo init --wait) so I'd rather stay consistent right now and remove this. The inconsistency concern is IMO bigger than portability one.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @zen-dog here - This is testing something that should be ensured globally not in each test. If we have this here, it will be copied to other tests and we end up with having this step duplicated everywhere.
We had this in the kudo e2e tests as well, I was glad we could remove it there.