Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(util/component): add Declared.SkipFutureMerges #48

Closed
wants to merge 2 commits into from

Conversation

SOF3
Copy link
Member

@SOF3 SOF3 commented Dec 16, 2024

No description provided.

@SOF3 SOF3 requested a review from DeliangFan December 16, 2024 10:37
@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 74.62687% with 17 lines in your changes missing coverage. Please review.

Project coverage is 38.48%. Comparing base (16d7816) to head (8574513).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
util/component/component.go 76.56% 14 Missing and 1 partial ⚠️
util/cmd/cmd.go 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #48      +/-   ##
==========================================
- Coverage   38.51%   38.48%   -0.04%     
==========================================
  Files          94       94              
  Lines        6631     6655      +24     
==========================================
+ Hits         2554     2561       +7     
- Misses       3932     3949      +17     
  Partials      145      145              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SOF3 SOF3 force-pushed the skip-future-merges branch from 6a6dc69 to 8574513 Compare December 17, 2024 10:28
@SOF3 SOF3 changed the title feat(util/component): add Declared.SkipFutureChanges feat(util/component): add Declared.SkipFutureMerges Dec 18, 2024
@SOF3 SOF3 closed this Jan 2, 2025
@SOF3
Copy link
Member Author

SOF3 commented Jan 2, 2025

Not a fan of this approach since it is non-composing. It seems unnecessary for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants