Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix eviction manager getEvictPodFromCandidates sort order #756

Merged

Conversation

luomingmeng
Copy link
Collaborator

What type of PR is this?

Bug fixes

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

gary-lgy
gary-lgy previously approved these changes Jan 6, 2025
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 56.82%. Comparing base (bbf3ec5) to head (d7db1e8).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
pkg/agent/evictionmanager/manager.go 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #756      +/-   ##
==========================================
+ Coverage   56.79%   56.82%   +0.03%     
==========================================
  Files         601      601              
  Lines       69839    69845       +6     
==========================================
+ Hits        39662    39688      +26     
+ Misses      25918    25893      -25     
- Partials     4259     4264       +5     
Flag Coverage Δ
unittest 56.82% <71.42%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luomingmeng luomingmeng merged commit a30d5aa into kubewharf:main Jan 13, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants