feat(qrm-plugins): synchronous GetAdvice API between qrm-plugins and sys-advisor #747
+5,036
−907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gary-lgy
requested review from
luomingmeng,
xu282934741 and
waynepeking348
as code owners
gary-lgy
changed the title
gary-lgy
force-pushed
the
qrm-sync
branch
2 times, most recently
from
6a46b8a to
b1bd308
Compare
gary-lgy
force-pushed
the
qrm-sync
branch
5 times, most recently
from
505ec78 to
473cb31
Compare
luomingmeng
reviewed
Dec 23, 2024
codecov.yml
Outdated
| @@ -26,6 +26,9 @@ coverage: | |||
|
|
|||
| ignore: | |||
| - "**/*_generated.*" | |||
| - "pkg/agent/qrm-plugins/cpu/dynamicpolicy/cpuadvisor/cpu.pb.go" | |||
| - "pkg/agent/qrm-plugins/advisorsvc/advisor_svc.pb.go" | |||
There was a problem hiding this comment.
it can also use generic match such as "*.pb.go"
| } | ||
| } | ||
|
|
||
| if err := ms.metaCache.RangeAndDeleteContainer(func(container *types.ContainerInfo) bool { |
There was a problem hiding this comment.
whether it will dead lock for it acquiring metaCache lock multiple times?
There was a problem hiding this comment.
no, line 141 acquires metaCache.Mutex, while line 153 acquires metaCache.podMutex.
gary-lgy
force-pushed
the
qrm-sync
branch
3 times, most recently
from
8274d33 to
553649d
Compare
…that support GetAdvice
…a new region if the got region's numa is different from container's binding numa
…d-region create a new region if numa binding container is not match its region binding numas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Replace
ListAndWatchapi from sysadvisor with synchronousGetAdvicerpc.What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer: