Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add memory limit plugin for memory advisor #583

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cccaoke
Copy link

@cccaoke cccaoke commented May 14, 2024

What type of PR is this?

What this PR does / why we need it:

add memory limit for reclaimed pods which set the limit in container spec

Which issue(s) this PR fixes:

Special notes for your reviewer:

@cccaoke cccaoke requested a review from nightmeng as a code owner May 14, 2024 06:42
@CLAassistant
Copy link

CLAassistant commented May 14, 2024

CLA assistant check
All committers have signed the CLA.

@cccaoke
Copy link
Author

cccaoke commented May 14, 2024

cc @WangZzzhe

Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 73.07692% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 56.20%. Comparing base (74b648c) to head (8c3eeeb).
Report is 2 commits behind head on main.

Files Patch % Lines
...in/qosaware/resource/memory/plugin/memory_limit.go 72.54% 9 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #583      +/-   ##
==========================================
+ Coverage   56.06%   56.20%   +0.14%     
==========================================
  Files         534      536       +2     
  Lines       49807    49881      +74     
==========================================
+ Hits        27924    28037     +113     
+ Misses      18325    18269      -56     
- Partials     3558     3575      +17     
Flag Coverage Δ
unittest 56.20% <73.07%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cccaoke cccaoke force-pushed the add-memory-limit branch 3 times, most recently from 45ae295 to c786657 Compare May 14, 2024 07:50
@cccaoke cccaoke force-pushed the add-memory-limit branch from c786657 to 42749c9 Compare May 20, 2024 06:17
@cccaoke cccaoke requested a review from waynepeking348 as a code owner May 20, 2024 06:17
@cccaoke cccaoke force-pushed the add-memory-limit branch 9 times, most recently from e0c8bd4 to 5e27a8d Compare May 20, 2024 11:54
@cccaoke cccaoke force-pushed the add-memory-limit branch from 5e27a8d to 8c3eeeb Compare May 20, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants