-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): bump kyverno to v1.10.3 #17
build(deps): bump kyverno to v1.10.3 #17
Conversation
…o replace Signed-off-by: Fabrizio Sestito <[email protected]>
Signed-off-by: Fabrizio Sestito <[email protected]>
Signed-off-by: Fabrizio Sestito <[email protected]>
f33536f
to
384b3dd
Compare
Signed-off-by: Fabrizio Sestito <[email protected]>
4224859
to
bf08395
Compare
Signed-off-by: Fabrizio Sestito <[email protected]>
bf08395
to
7c3ab59
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic job, I left some minor comments.
Could you also update the README please? It states the policy takes 90 MB, but this is no longer true thanks to this work :)
- name: Install wasm-opt | ||
run: | | ||
wget https://github.com/WebAssembly/binaryen/releases/download/version_116/binaryen-version_116-x86_64-linux.tar.gz | ||
tar -xzf binaryen-version_116-x86_64-linux.tar.gz | ||
sudo mv binaryen-version_116/bin/wasm-opt /usr/local/bin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpicking, can't we install it via system packages? Ubuntu has the package available
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@flavio I tried but it installs an old version (105) which has some memory leak and the runner gets reaped because of an OOM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, can you leave a comment about that?
Signed-off-by: Fabrizio Sestito <[email protected]>
Description