Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump kyverno to v1.10.3 #17

Merged

Conversation

fabriziosestito
Copy link
Contributor

@fabriziosestito fabriziosestito commented Oct 10, 2023

Description

  • Bumps kyverno to v1.10.3
  • Refactors validation.go to the current kyverno API
  • Reduces wasm size
  • Adds test ci workflow

@fabriziosestito fabriziosestito force-pushed the bump-kyverno-to-v1.10.3 branch 5 times, most recently from f33536f to 384b3dd Compare October 10, 2023 16:38
Signed-off-by: Fabrizio Sestito <[email protected]>
@fabriziosestito fabriziosestito force-pushed the bump-kyverno-to-v1.10.3 branch from 4224859 to bf08395 Compare October 10, 2023 17:48
Signed-off-by: Fabrizio Sestito <[email protected]>
@fabriziosestito fabriziosestito force-pushed the bump-kyverno-to-v1.10.3 branch from bf08395 to 7c3ab59 Compare October 10, 2023 17:48
@fabriziosestito fabriziosestito marked this pull request as ready for review October 10, 2023 17:50
@fabriziosestito fabriziosestito changed the title Bump kyverno to v1.10.3 build(deps): kyverno to v1.10.3 Oct 10, 2023
@fabriziosestito fabriziosestito changed the title build(deps): kyverno to v1.10.3 build(deps): bump kyverno to v1.10.3 Oct 10, 2023
Copy link
Member

@flavio flavio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic job, I left some minor comments.

Could you also update the README please? It states the policy takes 90 MB, but this is no longer true thanks to this work :)

Comment on lines +40 to +44
- name: Install wasm-opt
run: |
wget https://github.com/WebAssembly/binaryen/releases/download/version_116/binaryen-version_116-x86_64-linux.tar.gz
tar -xzf binaryen-version_116-x86_64-linux.tar.gz
sudo mv binaryen-version_116/bin/wasm-opt /usr/local/bin
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpicking, can't we install it via system packages? Ubuntu has the package available

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flavio I tried but it installs an old version (105) which has some memory leak and the runner gets reaped because of an OOM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, can you leave a comment about that?

.github/workflows/test.yml Show resolved Hide resolved
@fabriziosestito
Copy link
Contributor Author

@flavio README updated in 05290b1

@fabriziosestito fabriziosestito requested a review from a team October 11, 2023 12:46
@fabriziosestito fabriziosestito added kind/enhancement New feature or request dependencies Pull requests that update a dependency file labels Oct 11, 2023
@fabriziosestito fabriziosestito merged commit 301f60f into kubewarden:main Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file kind/enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants