Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community: add test, lint and coverage jobs #3824

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dhiller
Copy link
Contributor

@dhiller dhiller commented Dec 12, 2024

What this PR does / why we need it:

Based on PR kubevirt/community#368 where new make targets test and lint are introduced we are adding new presubmit jobs that execute them.

/hold to wait for above PR to land
/wg code-quality

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

@kubevirt-bot kubevirt-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. wg/code-quality Denotes an issue or PR that relates to the code-quality working group. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Dec 12, 2024
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from dhiller. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Based on PR kubevirt/community#368
where new make targets test, lint and coverage are introduced we are
adding new presubmit jobs that execute them.

Signed-off-by: Daniel Hiller <[email protected]>
@dhiller dhiller force-pushed the add-test-and-lint-for-community branch from 838b994 to ed06551 Compare December 13, 2024 09:58
@dhiller dhiller changed the title community: add test and lint jobs community: add test, lint and coverage jobs Dec 13, 2024
@aburdenthehand
Copy link
Member

/cc @EdDev for wg-code-quality

@kubevirt-bot kubevirt-bot requested a review from EdDev December 16, 2024 09:20
@kubevirt-bot
Copy link
Contributor

@aburdenthehand: GitHub didn't allow me to request PR reviews from the following users: for.

Note that only kubevirt members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @EdDev for wg-code-quality

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/M wg/code-quality Denotes an issue or PR that relates to the code-quality working group.
Projects
Status: Needs review
Development

Successfully merging this pull request may close these issues.

None yet

3 participants