Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore:(common-instancetypes): Add periodic and specify golang version #3817

Merged

Conversation

0xFelix
Copy link
Member

@0xFelix 0xFelix commented Dec 10, 2024

What this PR does / why we need it:

Add periodic to bump common-instancetype releases of release-1.2 branch
in Kubevirt's release-1.4 branch.

Specify that golang 1.22.9 should be installed in the presubmits of
common-instancetypes.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note:

None

@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Dec 10, 2024
@0xFelix
Copy link
Member Author

0xFelix commented Dec 10, 2024

/rehearse all

@kubevirt-bot
Copy link
Contributor

Rehearsal jobs created for this PR:

rehearsal-pull-common-instancetypes-kubevirt-functest-opensuse-leap
rehearsal-pull-common-instancetypes-kubevirt-functest-centos-stream-8
rehearsal-pull-common-instancetypes-kubevirt-functest-fedora-arm64
rehearsal-pull-common-instancetypes-kubevirt-functest-ubuntu-arm64
rehearsal-pull-common-instancetypes-kubevirt-functest-validation-os
rehearsal-pull-common-instancetypes-kubevirt-functest
rehearsal-pull-common-instancetypes-kubevirt-functest-fedora
rehearsal-pull-common-instancetypes-kubevirt-functest-opensuse-tumbleweed
rehearsal-pull-common-instancetypes-kubevirt-functest-centos-7
rehearsal-pull-common-instancetypes-kubevirt-functest-ubuntu
rehearsal-pull-common-instancetypes-kubevirt-functest-opensuse-leap-arm64
rehearsal-pull-common-instancetypes-kubevirt-functest-centos-stream-9
rehearsal-pull-common-instancetypes-kubevirt-functest-centos-stream-arm64

You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all
on this PR.

For a specific PR you can comment /rehearse {job-name}.

For a list of jobs that you can rehearse you can comment /rehearse ?.

@0xFelix 0xFelix force-pushed the common-instancetypes-bump-versions branch from 5de8f2e to 184ee6b Compare December 10, 2024 16:14
@0xFelix 0xFelix changed the title chore:(common-instancetypes): Bump KUBEVIRT_PROVIDER, add periodic and specify golang version chore:(common-instancetypes): Add periodic and specify golang version Dec 10, 2024
@0xFelix
Copy link
Member Author

0xFelix commented Dec 10, 2024

/rehearse all

@kubevirt-bot
Copy link
Contributor

Rehearsal jobs created for this PR:

rehearsal-pull-common-instancetypes-kubevirt-functest
rehearsal-pull-common-instancetypes-kubevirt-functest-fedora-arm64
rehearsal-pull-common-instancetypes-kubevirt-functest-centos-7
rehearsal-pull-common-instancetypes-kubevirt-functest-centos-stream-9
rehearsal-pull-common-instancetypes-kubevirt-functest-ubuntu-arm64
rehearsal-pull-common-instancetypes-kubevirt-functest-opensuse-leap
rehearsal-pull-common-instancetypes-kubevirt-functest-validation-os
rehearsal-pull-common-instancetypes-kubevirt-functest-centos-stream-8
rehearsal-pull-common-instancetypes-kubevirt-functest-fedora
rehearsal-pull-common-instancetypes-kubevirt-functest-centos-stream-arm64
rehearsal-pull-common-instancetypes-kubevirt-functest-ubuntu
rehearsal-pull-common-instancetypes-kubevirt-functest-opensuse-tumbleweed
rehearsal-pull-common-instancetypes-kubevirt-functest-opensuse-leap-arm64

You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all
on this PR.

For a specific PR you can comment /rehearse {job-name}.

For a list of jobs that you can rehearse you can comment /rehearse ?.

Add periodic to bump common-instancetype releases of release-1.2 branch
in Kubevirt's release-1.4 branch.

Signed-off-by: Felix Matouschek <[email protected]>
Specify that golang 1.22.9 should be installed in the presubmits of
common-instancetypes.

Signed-off-by: Felix Matouschek <[email protected]>
@0xFelix 0xFelix force-pushed the common-instancetypes-bump-versions branch from 184ee6b to c8a5d7b Compare December 16, 2024 10:42
@0xFelix
Copy link
Member Author

0xFelix commented Dec 16, 2024

/rehearse all

@kubevirt-bot
Copy link
Contributor

Rehearsal jobs created for this PR:

rehearsal-pull-common-instancetypes-kubevirt-functest-opensuse-leap-arm64
rehearsal-pull-common-instancetypes-kubevirt-functest-ubuntu-arm64
rehearsal-pull-common-instancetypes-kubevirt-functest-opensuse-leap
rehearsal-pull-common-instancetypes-kubevirt-functest-centos-stream-8
rehearsal-pull-common-instancetypes-kubevirt-functest
rehearsal-pull-common-instancetypes-kubevirt-functest-centos-stream-9
rehearsal-pull-common-instancetypes-kubevirt-functest-centos-stream-arm64
rehearsal-pull-common-instancetypes-kubevirt-functest-fedora
rehearsal-pull-common-instancetypes-kubevirt-functest-fedora-arm64
rehearsal-pull-common-instancetypes-kubevirt-functest-opensuse-tumbleweed
rehearsal-pull-common-instancetypes-kubevirt-functest-validation-os
rehearsal-pull-common-instancetypes-kubevirt-functest-centos-7
rehearsal-pull-common-instancetypes-kubevirt-functest-ubuntu

You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all
on this PR.

For a specific PR you can comment /rehearse {job-name}.

For a list of jobs that you can rehearse you can comment /rehearse ?.

@0xFelix
Copy link
Member Author

0xFelix commented Dec 16, 2024

/retest

@jcanocan
Copy link
Contributor

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2024
@0xFelix
Copy link
Member Author

0xFelix commented Dec 16, 2024

/rehearse rehearsal-pull-common-instancetypes-kubevirt-functest-fedora

@kubevirt-bot
Copy link
Contributor

Rehearsal jobs created for this PR:


You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all
on this PR.

For a specific PR you can comment /rehearse {job-name}.

For a list of jobs that you can rehearse you can comment /rehearse ?.

@0xFelix
Copy link
Member Author

0xFelix commented Dec 16, 2024

/rehearse pull-common-instancetypes-kubevirt-functest-fedora

@kubevirt-bot
Copy link
Contributor

Rehearsal jobs created for this PR:

rehearsal-pull-common-instancetypes-kubevirt-functest-fedora

You can trigger rehearsal for all jobs by commenting either /rehearse or /rehearse all
on this PR.

For a specific PR you can comment /rehearse {job-name}.

For a list of jobs that you can rehearse you can comment /rehearse ?.

Copy link
Member

@lyarwood lyarwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lyarwood

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2024
@kubevirt-bot kubevirt-bot merged commit c0320ed into kubevirt:main Dec 17, 2024
18 checks passed
@kubevirt-bot
Copy link
Contributor

@0xFelix: Updated the job-config configmap in namespace kubevirt-prow at cluster default using the following files:

  • key common-instancetypes-periodics.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/common-instancetypes/common-instancetypes-periodics.yaml
  • key common-instancetypes-presubmits.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/common-instancetypes/common-instancetypes-presubmits.yaml

In response to this:

What this PR does / why we need it:

Add periodic to bump common-instancetype releases of release-1.2 branch
in Kubevirt's release-1.4 branch.

Specify that golang 1.22.9 should be installed in the presubmits of
common-instancetypes.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note:

None

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants