-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubevirt,monitoring: Update monitoring presubmit to v1.31 and add periodic monitoring lane #3806
base: main
Are you sure you want to change the base?
Conversation
…ovider The v1.29 kubernetes provider will be removed from kubevirtci soon - update the monitoring lane to use the latest stable provider Signed-off-by: Brian Carey <[email protected]>
Adding a periodic lane for the sig-monitoring e2e tests allows us to check the health of this lane against the main branch and also gives us feedback on the state of any quarantined monitoring e2e tests Signed-off-by: Brian Carey <[email protected]>
/rehearse |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Rehearsal jobs created for this PR:
You can trigger rehearsal for all jobs by commenting either For a specific PR you can comment For a list of jobs that you can rehearse you can comment |
testgrid-dashboards: kubevirt-periodics | ||
testgrid-days-of-results: "60" | ||
cluster: kubevirt-prow-workloads | ||
cron: 30 0,7 * * * |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we only testing twice a day here? Also I find the distance of seven hours a bit odd. What's the reason for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just thought that twice daily would be enough for this lane
I am open to suggestions otherwise though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question inline.
What this PR does / why we need it:
The v1.29 kubernetes provider will be removed from kubevirtci soon -
update the monitoring lane to use the latest stable provider
Adding a periodic lane for the sig-monitoring e2e tests allows us to
check the health of this lane against the main branch and also gives us
feedback on the state of any quarantined monitoring e2e tests
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
/cc @machadovilaca @sradco @dhiller
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
Release note: