-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prow, plugin, help: add required labels, enable for kubevirtci and project-infra #3306
Conversation
We add the labels that are required for the prow help plugin to work. Also we enable them for the kubevirtci and the project-infra repos and add the initial configuration. Signed-off-by: Daniel Hiller <[email protected]>
/unhold since it's unnecessary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Should we wait for the help-wanted doc to be merged first?
Don't think so, should merge soon enough. We can then already verify whether it's working ok. |
Also the label update is only done on a 24h interval IIRC, so it will take a while |
/unhold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brianmcarey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@dhiller: Updated the following 2 configmaps:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
We add the labels that are required for the prow help plugin to work. Also we enable them for the kubevirtci and the project-infra repos and add the initial configuration. Signed-off-by: Daniel Hiller <[email protected]>
What this PR does / why we need it:
We add the labels that are required for the prow help plugin to work.
Also we enable them for the kubevirtci and the project-infra repos
and add the initial configuration.
This is related to the help-wanted doc added with this PR
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
/cc @xpivarc @brianmcarey
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
Release note: