Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prow, plugin, help: add required labels, enable for kubevirtci and project-infra #3306

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

dhiller
Copy link
Contributor

@dhiller dhiller commented Mar 8, 2024

What this PR does / why we need it:

We add the labels that are required for the prow help plugin to work.
Also we enable them for the kubevirtci and the project-infra repos
and add the initial configuration.

This is related to the help-wanted doc added with this PR

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

/cc @xpivarc @brianmcarey

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note:


We add the labels that are required for the prow help plugin to work.
Also we enable them for the kubevirtci and the project-infra repos
and add the initial configuration.

Signed-off-by: Daniel Hiller <[email protected]>
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/S labels Mar 8, 2024
@dhiller dhiller changed the title prow, plugin, help: add required labels, enable prow, plugin, help: add required labels, enable for kubevirtci and project-infra Mar 8, 2024
@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 8, 2024
@dhiller
Copy link
Contributor Author

dhiller commented Mar 8, 2024

/unhold since it's unnecessary

Copy link
Member

@brianmcarey brianmcarey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Should we wait for the help-wanted doc to be merged first?

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 8, 2024
@dhiller
Copy link
Contributor Author

dhiller commented Mar 8, 2024

/lgtm

Should we wait for the help-wanted doc to be merged first?

Don't think so, should merge soon enough. We can then already verify whether it's working ok.

@dhiller dhiller requested a review from brianmcarey March 8, 2024 10:30
@dhiller
Copy link
Contributor Author

dhiller commented Mar 8, 2024

Also the label update is only done on a 24h interval IIRC, so it will take a while

@dhiller
Copy link
Contributor Author

dhiller commented Mar 8, 2024

/unhold

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 8, 2024
Copy link
Member

@brianmcarey brianmcarey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brianmcarey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 8, 2024
@kubevirt-bot kubevirt-bot merged commit 441ebc3 into kubevirt:main Mar 8, 2024
4 checks passed
@kubevirt-bot
Copy link
Contributor

@dhiller: Updated the following 2 configmaps:

  • label-config configmap in namespace kubevirt-prow at cluster default using the following files:
    • key labels.yaml using file github/ci/prow-deploy/kustom/base/configs/current/labels/labels.yaml
  • plugins configmap in namespace kubevirt-prow at cluster default using the following files:
    • key plugins.yaml using file github/ci/prow-deploy/kustom/base/configs/current/plugins/plugins.yaml

In response to this:

What this PR does / why we need it:

We add the labels that are required for the prow help plugin to work.
Also we enable them for the kubevirtci and the project-infra repos
and add the initial configuration.

This is related to the help-wanted doc added with this PR

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

/cc @xpivarc @brianmcarey

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note:


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Barakmor1 pushed a commit to Barakmor1/project-infra that referenced this pull request Apr 24, 2024
We add the labels that are required for the prow help plugin to work.
Also we enable them for the kubevirtci and the project-infra repos
and add the initial configuration.

Signed-off-by: Daniel Hiller <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants