Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run hack/bump-prow-job-images.sh #3134

Merged
merged 1 commit into from
Dec 23, 2023

Conversation

kubevirt-bot
Copy link
Contributor

Bump Prow Job images
@kubevirt/prow-job-taskforce
/cc none

@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/XL labels Dec 20, 2023
Copy link
Member

@brianmcarey brianmcarey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/cc @dhiller

@kubevirt-bot kubevirt-bot requested a review from dhiller December 20, 2023 10:46
@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 20, 2023
@dhiller
Copy link
Contributor

dhiller commented Dec 20, 2023

@dhiller's review-bot says:

  • 👎 This doesn't look like a simple prow job image bump.
    `github/ci/prow-deploy/files/jobs/kubevirt/containerized-data-importer/containerized-data-importer-presubmits.yaml` ```diff nodeSelector: type: bare-metal-external containers:
  •    - image:  quay.io/kubevirtci/bootstrap:v20231115-51a244f
    
  •    - image:  quay.io/kubevirtci/bootstrap:v20231219-bf5e580
         command:
           - "/usr/local/bin/runner.sh"
           - "/bin/sh"
    
    </details>
    
    

This PR does not satisfy at least one automated review criteria.

This PR does not require further manual action.

Note: botreview (#3100) is a Work In Progress!

@dhiller
Copy link
Contributor

dhiller commented Dec 20, 2023

@brianmcarey there's a merge conflict here, let's wait for the next update

@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 20, 2023
@dhiller
Copy link
Contributor

dhiller commented Dec 20, 2023

@dhiller's review-bot says:

👎 This doesn't look like a simple prow job image bump.

github/ci/prow-deploy/files/jobs/kubevirt/containerized-data-importer/containerized-data-importer-presubmits.yaml

       nodeSelector:
         type: bare-metal-external
       containers:
-        - image:  quay.io/kubevirtci/bootstrap:v20231115-51a244f
+        - image:  quay.io/kubevirtci/bootstrap:v20231219-bf5e580
           command:
             - "/usr/local/bin/runner.sh"
             - "/bin/sh"

This PR does not satisfy at least one automated review criteria.

This PR does not require further manual action.

Note: botreview (#3100) is a Work In Progress!

@dhiller
Copy link
Contributor

dhiller commented Dec 20, 2023

@dhiller's review-bot says:

👎 This doesn't look like a simple prow job image bump.

github/ci/prow-deploy/files/jobs/kubevirt/containerized-data-importer/containerized-data-importer-presubmits.yaml

       nodeSelector:
         type: bare-metal-external
       containers:
-        - image:  quay.io/kubevirtci/bootstrap:v20231115-51a244f
+        - image:  quay.io/kubevirtci/bootstrap:v20231219-bf5e580
           command:
             - "/usr/local/bin/runner.sh"
             - "/bin/sh"

This PR does not satisfy at least one automated review criteria.

This PR does not require further manual action.

Note: botreview (#3100) is a Work In Progress!

@brianmcarey
Copy link
Member

/lgtm cancel

@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 20, 2023
@kubevirt-bot kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 21, 2023
@dhiller
Copy link
Contributor

dhiller commented Dec 21, 2023

@dhiller's review-bot says:

👍 This looks like a simple prow job image bump.

This PR satisfies all automated review criteria.

/lgtm
/approve

This PR does not require further manual action.

Note: botreview (#3100) is a Work In Progress!

@kubevirt-bot kubevirt-bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 21, 2023
@dhiller
Copy link
Contributor

dhiller commented Dec 21, 2023

/lgtm cancel

@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 21, 2023
@dhiller
Copy link
Contributor

dhiller commented Dec 22, 2023

@dhiller's review-bot says:

👍 This looks like a simple prow job image bump.

This PR satisfies all automated review criteria.

/lgtm
/approve

This PR does not require further manual action.

Note: botreview (#3100) is a Work In Progress!

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 22, 2023
@kubevirt-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhiller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 22, 2023
@dhiller
Copy link
Contributor

dhiller commented Dec 22, 2023

/lgtm cancel

@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 22, 2023
@kubevirt-bot kubevirt-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 23, 2023
Copy link
Member

@brianmcarey brianmcarey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 23, 2023
@kubevirt-bot kubevirt-bot merged commit 2811573 into kubevirt:main Dec 23, 2023
5 checks passed
@kubevirt-bot
Copy link
Contributor Author

@kubevirt-bot: Updated the job-config configmap in namespace kubevirt-prow at cluster default using the following files:

  • key kubemacpool-postsubmits.yaml using file github/ci/prow-deploy/files/jobs/k8snetworkplumbingwg/kubemacpool/kubemacpool-postsubmits.yaml
  • key kubemacpool-presubmits.yaml using file github/ci/prow-deploy/files/jobs/k8snetworkplumbingwg/kubemacpool/kubemacpool-presubmits.yaml
  • key ovs-cni-postsubmits.yaml using file github/ci/prow-deploy/files/jobs/k8snetworkplumbingwg/ovs-cni/ovs-cni-postsubmits.yaml
  • key ovs-cni-presubmits.yaml using file github/ci/prow-deploy/files/jobs/k8snetworkplumbingwg/ovs-cni/ovs-cni-presubmits.yaml
  • key cluster-api-provider-kubevirt-presubmits.yaml using file github/ci/prow-deploy/files/jobs/kubernetes-sigs/cluster-api-provider-kubevirt/cluster-api-provider-kubevirt-presubmits.yaml
  • key applications-aware-quota-postsubmits.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/applications-aware-quota/applications-aware-quota-postsubmits.yaml
  • key applications-aware-quota-presubmits.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/applications-aware-quota/applications-aware-quota-presubmits.yaml
  • key bridge-marker-postsubmits.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/bridge-marker/bridge-marker-postsubmits.yaml
  • key bridge-marker-presubmits.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/bridge-marker/bridge-marker-presubmits.yaml
  • key cloud-provider-kubevirt-presubmits.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/cloud-provider-kubevirt/cloud-provider-kubevirt-presubmits.yaml
  • key cluster-network-addons-operator-postsubmits.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/cluster-network-addons-operator/cluster-network-addons-operator-postsubmits.yaml
  • key cluster-network-addons-operator-presubmits.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/cluster-network-addons-operator/cluster-network-addons-operator-presubmits.yaml
  • key common-instancetypes-postsubmits.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/common-instancetypes/common-instancetypes-postsubmits.yaml
  • key common-instancetypes-presubmits.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/common-instancetypes/common-instancetypes-presubmits.yaml
  • key containerdisks-periodics.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/containerdisks/containerdisks-periodics.yaml
  • key containerdisks-presubmits.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/containerdisks/containerdisks-presubmits.yaml
  • key containerized-data-importer-postsubmits.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/containerized-data-importer/containerized-data-importer-postsubmits.yaml
  • key containerized-data-importer-presubmits.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/containerized-data-importer/containerized-data-importer-presubmits.yaml
  • key csi-driver-postsubmits.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/csi-driver/csi-driver-postsubmits.yaml
  • key csi-driver-presubmits.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/csi-driver/csi-driver-presubmits.yaml
  • key hostpath-provisioner-operator-postsubmits.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/hostpath-provisioner-operator/hostpath-provisioner-operator-postsubmits.yaml
  • key hostpath-provisioner-operator-presubmits.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/hostpath-provisioner-operator/hostpath-provisioner-operator-presubmits.yaml
  • key hostpath-provisioner-postsubmits.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/hostpath-provisioner/hostpath-provisioner-postsubmits.yaml
  • key hostpath-provisioner-presubmits.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/hostpath-provisioner/hostpath-provisioner-presubmits.yaml
  • key hyperconverged-cluster-operator-periodics.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/hyperconverged-cluster-operator/hyperconverged-cluster-operator-periodics.yaml
  • key hyperconverged-cluster-operator-postsubmits.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/hyperconverged-cluster-operator/hyperconverged-cluster-operator-postsubmits.yaml
  • key hyperconverged-cluster-operator-presubmits.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/hyperconverged-cluster-operator/hyperconverged-cluster-operator-presubmits.yaml
  • key kubectl-virt-plugin-postsubmits.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/kubectl-virt-plugin/kubectl-virt-plugin-postsubmits.yaml
  • key kubectl-virt-plugin-presubmits.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/kubectl-virt-plugin/kubectl-virt-plugin-presubmits.yaml
  • key kubesecondarydns-presubmits.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/kubesecondarydns/kubesecondarydns-presubmits.yaml
  • key kubevirt-tutorial-periodics.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/kubevirt-tutorial/kubevirt-tutorial-periodics.yaml
  • key kubevirt-velero-plugin-periodics.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/kubevirt-velero-plugin/kubevirt-velero-plugin-periodics.yaml
  • key kubevirt-velero-plugin-postsubmits.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/kubevirt-velero-plugin/kubevirt-velero-plugin-postsubmits.yaml
  • key kubevirt-velero-plugin-presubmits.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/kubevirt-velero-plugin/kubevirt-velero-plugin-presubmits.yaml
  • key kubevirt-periodics.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/kubevirt/kubevirt-periodics.yaml
  • key kubevirt-postsubmits.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/kubevirt/kubevirt-postsubmits.yaml
  • key kubevirt-presubmits.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/kubevirt/kubevirt-presubmits.yaml
  • key kubevirtci-periodics.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/kubevirtci/kubevirtci-periodics.yaml
  • key kubevirtci-presubmits.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/kubevirtci/kubevirtci-presubmits.yaml
  • key libguestfs-appliance-periodics.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/libguestfs-appliance/libguestfs-appliance-periodics.yaml
  • key libguestfs-appliance-presubmits.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/libguestfs-appliance/libguestfs-appliance-presubmits.yaml
  • key macvtap-cni-postsubmits.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/macvtap-cni/macvtap-cni-postsubmits.yaml
  • key macvtap-cni-presubmits.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/macvtap-cni/macvtap-cni-presubmits.yaml
  • key managed-tenant-quota-postsubmits.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/managed-tenant-quota/managed-tenant-quota-postsubmits.yaml
  • key managed-tenant-quota-presubmits.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/managed-tenant-quota/managed-tenant-quota-presubmits.yaml
  • key node-maintenance-operator-postsubmits.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/node-maintenance-operator/node-maintenance-operator-postsubmits.yaml
  • key node-maintenance-operator-presubmits-master.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/node-maintenance-operator/node-maintenance-operator-presubmits-master.yaml
  • key project-infra-periodics.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/project-infra/project-infra-periodics.yaml
  • key project-infra-postsubmits.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/project-infra/project-infra-postsubmits.yaml
  • key project-infra-presubmits.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/project-infra/project-infra-presubmits.yaml
  • key qe-tools-presubmits.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/qe-tools/qe-tools-presubmits.yaml
  • key secrets-periodics.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/secrets/secrets-periodics.yaml
  • key terraform-provider-kubevirt-presubmits.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/terraform-provider-kubevirt/terraform-provider-kubevirt-presubmits.yaml
  • key test-benchmarks-presubmits.yaml using file github/ci/prow-deploy/files/jobs/kubevirt/test-benchmarks/test-benchmarks-presubmits.yaml
  • key kubernetes-nmstate-postsubmits.yaml using file github/ci/prow-deploy/files/jobs/nmstate/kubernetes-nmstate/kubernetes-nmstate-postsubmits.yaml
  • key kubernetes-nmstate-presubmits.yaml using file github/ci/prow-deploy/files/jobs/nmstate/kubernetes-nmstate/kubernetes-nmstate-presubmits.yaml
  • key nmstate-presubmits.yaml using file github/ci/prow-deploy/files/jobs/nmstate/nmstate/nmstate-presubmits.yaml

In response to this:

Bump Prow Job images
@kubevirt/prow-job-taskforce
/cc none

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants