s390x enablement WIP

[cfilleke]

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #3356

Special notes for your reviewer:
WIP still needs rebase/merge conflict resolution

Release note:

enables s390x native build

[kubevirt-bot]

Hi @cfilleke. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[awels]

This is the one we want in, together with the fix for the unit test? I can waive the failing unit tests for this PR, so we can get this in so the other PR can pass. Although I think the other PR would have no issue merging even without this.

[Davo911]

This is the one we want in, together with the fix for the unit test? I can waive the failing unit tests for this PR, so we can get this in so the other PR can pass. Although I think the other PR would have no issue merging even without this.

You're right, the unit test enablement can already be merged in without causing issues before this.
I'll convert it to a proper PR.

[cfilleke]

If we're going to be using cross-compile with this, I'll need to merge the changes to the Dockerfile first; however, if we can build on the new cloud s390x external ci/cd cluster (and I would suggest we do that) then we need to configure that to build & register the build-the-builder container first; also have some questions about at what stage in the build-test lifecycle the make rpm-deps is executed. Thanks!

[dominikholler]

Building containerized-data-importer for s390x failed for me with

 final command line arguments: "build" "-o" "/remote-source/app/_out/cmd/cdi-importer/cdi-importer" "-tags" "strictfipsruntime" "-ldflags" "-extldflags $static_flag" "-ldflags" "-X 'kubevirt.io/containerized-data-importer/pkg/version.buildDate=2024-08-15T15:58:56Z'"
invoking real go binary
 # kubevirt.io/containerized-data-importer/pkg/util
 ../../pkg/util/util.go:116:9: invalid operation: int64(stat.Bavail) * stat.Bsize (mismatched types int64 and uint32)
Exited with: 1

[cfilleke]

/retest

[kubevirt-bot]

@cfilleke: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[cfilleke]

/rehearse

[jschintag]

/ok-to-test

[awels]

Can you rebase? Seems like there are some issues there now.

[cfilleke]

/test pull-cdi-verify-go-mod

[awels]

To fix, run make generate and make generate-verify to ensure nothing is being generated

[cfilleke]

Both make generate and make generate-verify on s390x require the existence of a kubevirt-cdi-bazel-builder container in the tagged manifest in quay.io which does not yet exist, as the code of this PR is part of the creation of that container.

The results of make generate and make generate-verify on s390x and x86 are in this gist: https://gist.github.com/cfilleke/3ab5bb4d386be007f70d9d97e574e5d4

[cfilleke]

pull-cdi-unit-test fails with the same error that updating rpm/README.md in PR #3409 fails, so it's not clear that this would be resolved with a code change @awels

possibly they were both trying to run the same test at once, which caused both to fail?

[cfilleke]

/test pull-cdi-unit-test

[cfilleke]

/test pull-containerized-data-importer-e2e-nfs

[cfilleke]

/test pull-containerized-data-importer-e2e-nfs

[cfilleke]

All tests passed except 'tide' and this apears to now require only /lgtm /approve now @aglitke @alromeros @ShellyKa13 but it's still an XXL so please feel free to ask me questions. Thanks!

[coveralls]

coverage: 59.144% (-0.003%) from 59.147%
when pulling 175826c on cfilleke:s390x-xc-rb
into bc7cf46 on kubevirt:main.

[cfilleke]

/test pull-cdi-linter

[cfilleke]

make all build test on s390x results here: https://gist.github.com/cfilleke/a4dcbad9a9ce9472ad3d74bdbedd4d62

[awels]

/approve

[kubevirt-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awels

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [awels]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment