Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sig-observability deatils #353

Conversation

sradco
Copy link
Contributor

@sradco sradco commented Nov 19, 2024

What this PR does / why we need it:
This PR add details about sig-observability like contact information and weekly meetings deatils.

Signed-off-by: Shirly Radco [email protected]
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note:

NONE

@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Nov 19, 2024
@sradco
Copy link
Contributor Author

sradco commented Nov 19, 2024

@machadovilaca FYI

@sradco
Copy link
Contributor Author

sradco commented Nov 19, 2024

/hold
Im missing a meeting link. Will unhold when this is updated.

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 19, 2024
sigs.yaml Outdated Show resolved Hide resolved
sigs.yaml Outdated Show resolved Hide resolved
@sradco
Copy link
Contributor Author

sradco commented Nov 20, 2024

/unhold

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 20, 2024
@aburdenthehand
Copy link
Member

/lgtm
@dhiller PTAL?

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2024
@sradco
Copy link
Contributor Author

sradco commented Nov 20, 2024

oh.. I didnt run make generate. Will do that now.

Signed-off-by: Shirly Radco <[email protected]>
@sradco sradco force-pushed the update_sig_observability_details_in_sigs_yaml branch from ae14590 to 37069fe Compare November 20, 2024 12:28
@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2024
@aburdenthehand
Copy link
Member

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2024
Copy link
Contributor

@dhiller dhiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @sradco

/lgtm

@sradco
Copy link
Contributor Author

sradco commented Nov 23, 2024

@aburdenthehand Hi, who can approve the PR?

@aburdenthehand
Copy link
Member

/approve

@kubevirt-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aburdenthehand

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 24, 2024
@kubevirt-bot kubevirt-bot merged commit a692308 into kubevirt:main Nov 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants