community,labels,sig-list: update/remove labels #348
Conversation
kubevirt-bot
added
kind/cleanup
Updates labels on sigs to the ones that exist and are used, where others that don't exist are removed. Signed-off-by: Daniel Hiller <[email protected]>
dhiller
force-pushed
the
update-labels
branch
from
14bfcdb to
0be0470
Compare
|
@aburdenthehand added |
|
/lgtm |
|
FYI @awels @EdDev @alaypatel07 |
|
/lgtm |
| @@ -21,7 +21,7 @@ Each group's material is in its subdirectory in this project. | |||
|
|
|||
| | Name | Label [1] | Chairs [2] | Contact | Meetings | | |||
| |------|-----------|---------|---------|----------| | |||
| |[KubeVirt Community](kubevirt-community/charter.md) |[kubevirt-community](https://github.com/kubevirt/kubevirt/labels/kubevirt-community)|<ol></ol> |[Slack](virtualization)<br/> [Mailing List](https://groups.google.com/forum/#!forum/kubevirt-dev) |<ul><li>Regular KubeVirt Community Meeting: [ Wednesday at 15:00 UTC (weekly) ](https://zoom.us/j/92221936273)</li></ul> | | |||
| |[KubeVirt Community](kubevirt-community/charter.md) |[](https://github.com/kubevirt/kubevirt/labels/)|<ol></ol> |[Slack](virtualization)<br/> [Mailing List](https://groups.google.com/forum/#!forum/kubevirt-dev) |<ul><li>Regular KubeVirt Community Meeting: [ Wednesday at 15:00 UTC (weekly) ](https://zoom.us/j/92221936273)</li></ul> | | |||
There was a problem hiding this comment.
Why? That makes the link invisible
There was a problem hiding this comment.
I think it's right to do this since the label kubevirt-community doesn't exist: https://github.com/kubevirt/project-infra/blob/main/docs/labels.md
We can argue about the flaw in the template leading to these empty edgy braces, but I think that's just a minor issue, which we can follow up on. WDYT?
There was a problem hiding this comment.
I'd prefer if the generator could put nothing there instead of a broken and unclickable link, but if it's too much work then whatever.
There was a problem hiding this comment.
I'm not saying it's too much work - I have PR #346 where I am working on (which you already reviewed) and where I'll add the change.
kubevirt-bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jean-edouard The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
@jean-edouard I am going to remove the hold here, and rebase the changes inside the other PR if you don't mind. |
|
/unhold |
kubevirt-bot
removed
the
do-not-merge/hold
What this PR does / why we need it:
Updates labels on sigs.yaml to the ones that exist and are used, where others that don't exist are removed.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
/kind cleanup
/cc @aburdenthehand
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
Release note: