Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community,OWNERS: self nomination of dhiller as reviewer #328

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

dhiller
Copy link
Contributor

@dhiller dhiller commented Sep 26, 2024

I hereby nominate myself as a reviewer for the kubevirt/community repository, with the long term goal of becoming an approver.

I currently am one of the SIG CI chairs and also one of the SIG buildsystem chairs. I am employed by Red Hat and active in the KubeVirt community since 2019.

I have a history of contributions to this repository, where the main focus has been

  • documentation of automation,
  • community processes and
  • automatic document generation for community matters.

I would like to be a reviewer so that I can help working on improving community documentation, processes and automation for the KubeVirt community.

Note

I specifically will not do technical reviews of design proposals, since I see this as

  1. way over my head and
  2. a responsibility of the SIGs.

FYI @aburdenthehand @vladikr

@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Sep 26, 2024
@alicefr
Copy link
Member

alicefr commented Sep 26, 2024

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2024
@aburdenthehand
Copy link
Member

/lgtm
(will approve in a few days if no one beats me to it or objects)
I'd like to add that Daniel also helps out with moderation of the community meeting, regularly represents the project at at a variety of conferences, and is heavily invested in community matters in general. His involvement in this repo and the experience that he brings will be greatly appreciated. Thank you Daniel!

@jean-edouard
Copy link
Contributor

/lgtm

@vladikr
Copy link
Member

vladikr commented Sep 26, 2024

/approve

@kubevirt-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vladikr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 26, 2024
@kubevirt-bot kubevirt-bot merged commit 76b09b5 into kubevirt:main Sep 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants