make the vddk creation more fluent #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: borod108 <[email protected]>
Signed-off-by: borod108 <[email protected]>
borod108
force-pushed
the
task/automate-vddk
branch
from
4386646 to
07faf10
Compare
| source: redhat-operators | ||
| sourceNamespace: openshift-marketplace | ||
| --- | ||
|
|
||
| allowVolumeExpansion: true |
There was a problem hiding this comment.
So do I understand corectly that you now rely on assisted installer to configure LVMCluster CR, but the only think you can't configure is the storage class, so you do it using gitops?
There was a problem hiding this comment.
Cool! Can you please investigate if you can use this feature:
openshift/assisted-installer#940
To setup storage class?
There was a problem hiding this comment.
wow this is a super cool feature! I will investigate it, thank you!
| apiVersion: v1 | ||
| kind: Secret | ||
| metadata: | ||
| name: vmware-credentials |
There was a problem hiding this comment.
Why do we need empty credentials?
There was a problem hiding this comment.
machacekondra
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added custom manifests - if they are applied all the prerequisites to run the main manifest are installed and no other manual intervention is required