agent/agent: Refactor run command #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tupyy
force-pushed
the
refractor-agent-server
branch
from
6fe0b98 to
cbd0872
Compare
tupyy
force-pushed
the
refractor-agent-server
branch
7 times, most recently
from
8bbfb31 to
2ff77cf
Compare
internal/agent/config.go
Outdated
| @@ -27,7 +27,7 @@ const ( | |||
| // DefaultPlannerEndpoint is the default address of the migration planner server | |||
| DefaultPlannerEndpoint = "https://localhost:7443" | |||
| // DefaultHealthCheck is the default value for health check interval in seconds. | |||
| DefaultHealthCheck = 5 * 60 // 5 min | |||
| DefaultHealthCheck = 10 // 5 min | |||
There was a problem hiding this comment.
Please fix the comment, also maybe explain in comment why it's 10seconds now.
| case <-updateTicker.C: | ||
| } | ||
|
|
||
| // check for health. Send requests only if we have connectivity |
There was a problem hiding this comment.
Can you please explain why the code below is not part of case <-updateTicker.C:?
There was a problem hiding this comment.
It is but I've put it out of the scope for better readability. the select will block until tick or cancel().
The run command has been refractor to make it simpler. The inventory status method does not have a loop anymore and it is called from the agent itself. The health check state is checked before sending update requests. The idea is to reorganize the "inventory" and "healthcheck" into a stateless services and let the agent control everything. This commit does not change the logic of the agent in any way, it just tries to improve organization of the code and the readability. Signed-off-by: Cosmin Tupangiu <[email protected]>
tupyy
force-pushed
the
refractor-agent-server
branch
from
2ff77cf to
40b330b
Compare
machacekondra
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The run command has been refractor to make it simpler. The inventory status method does not have a loop anymore and it is called from the agent itself.
The health check state is checked before sending update requests.
The idea is to reorganize the "inventory" and "healthcheck" into a stateless services and let the agent control everything.
This commit does not change the logic of the agent in any way, it just tries to improve organization of the code and the readability.
Signed-of-by: Cosmin Tupangiu [email protected]