Add end to end tests #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
machacekondra
force-pushed
the
kind
branch
2 times, most recently
from
c0a6aa0 to
f722b3c
Compare
This PR add end to end testing.
We use github action CI called end to end, which is executed in every PR.
Github CI's ubuntu now support KVM, so tests are quite fast.
The process is:
setup kind and libvirt
Deploy vCsim, which is used has vcenter
Deploy registry where we push agent container
Build container of agent and push it to registry
Build container of agent-service and deploy it on kind
run tests
The tests are using ginkgo. There are few helper methods implemented to
help manage VM and sources. The first end to end test flow:
Before each test:
Create source
Download OVA image & extract it
Run libvirt VM using the ISO from OVA
Wait for VM IP
Wait for planner-agent service to be running
Test flow:
Send the vCenter credentials to agent
Wait until the source is reporting the up-to-date state
Signed-off-by: Ondra Machacek <[email protected]>
bardielle
reviewed
Oct 27, 2024
| @@ -0,0 +1,20 @@ | |||
| # Running integration tests | |||
bardielle
reviewed
Oct 27, 2024
| sourceId, err = svc.Create("testsource") | ||
| Expect(err).To(BeNil()) | ||
| Expect(sourceId).ToNot(BeNil()) | ||
| err = agent.Run(sourceId) |
There was a problem hiding this comment.
Greate work!
I see that agent.Run creates a n agent VM but I can't find where do we remove it?
There was a problem hiding this comment.
In AfterEach method we call 'agent.Remove()' that will remove the VM
bardielle
reviewed
Oct 27, 2024
bardielle
approved these changes
Oct 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add end to end testing.
We use github action CI called
end to end, which is executed in every PR.Github CI's ubuntu now support KVM, so tests are quite fast.
The process is:
The tests are using ginkgo. There are few helper methods implemented to help manage VM and sources.
The first end to end test flow:
Before each test:
planner-agentservice to be runningTest flow:
After each test:
If failed:
See the test run: https://github.com/kubev2v/migration-planner/actions/runs/11531405152/job/32102064538?pr=51