store: Add transactions #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/retest |
|
Looks good. I think adding the |
either that or adding a |
Transaction are needed because we have to leave the db in a clean state if something happen while mutating data. Currently, we have only one resource _source_ but, with the new multi source model, we'll need to mutate two resources _agent_ and _source_ in the same operation. This requires that the op is done in a transaction. This commit adds transaction support into the store. The code is largly based on the transaction implementation found in other RH service (e.g. uhc-service-account) but is has been made simplier to fit our needs. The transactions are wrapped into a context and passed to store when services are asking for _source_ repository (for now, we have only one. Soon to be more). The store checks the context and if it finds a transaction it will use it to create the source repository. Otherwise, it uses its own db connection. Methods for _commit_ and _rollback_ are added so a service can rollback or commit a transaction if an error occurs. Signed-off-by: Cosmin Tupangiu <[email protected]>
| ctx, err := store.NewTransactionContext(context.TODO()) | ||
| Expect(err).To(BeNil()) | ||
|
|
||
| source, err := store.Source().Create(ctx, api.SourceCreate{Name: "test", SshKey: "some key"}) |
There was a problem hiding this comment.
I really need to add the validation to SSH key ;)
machacekondra
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transactions are needed because we must leave the db clean if something happens while mutating data. Currently, we have only one resource source but, with the new multi source model, we'll need to mutate two resources agent and source in the same operation. This requires that the op is done in a transaction.
This commit adds transaction support into the store. The code is largly based on the transaction implementation found in other RH service (e.g. uhc-service-account) but is has been made simplier to fit our needs.
The transactions are wrapped into a context and passed to the store when services are asking for source repository (for now, we have only one. Soon to be more). The store checks the context and if it finds a transaction it will use it to create the source repository. Otherwise, it uses its own db connection.
Methods for commit and rollback are added so a service can rollback or commit a transaction if an error occurs.
Signed-off-by: Cosmin Tupangiu [email protected]