Modify the testing of vmware credentials #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tupyy
reviewed
Oct 10, 2024
machacekondra
force-pushed
the
fixcredentialscheck
branch
from
85f0009 to
7612334
Compare
tupyy
approved these changes
Oct 10, 2024
machacekondra
force-pushed
the
fixcredentialscheck
branch
from
7612334 to
cb022f9
Compare
This PR modify the testing of vmware credentials, that we add the /sdk suffix in case it's missing. Also we return proper error return codes in case something is wrong. Signed-off-by: Ondra Machacek <[email protected]>
machacekondra
force-pushed
the
fixcredentialscheck
branch
from
cb022f9 to
b64572e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modify the testing of vmware credentials so it follows the code of the forklift project. Also we return proper error return codes in case something is wrong.