Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch Vsphere instanceUuid #1224

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Fetch Vsphere instanceUuid #1224

merged 1 commit into from
Nov 28, 2024

Conversation

machacekondra
Copy link
Contributor

This PR add fetching of the instanceUuid to About model.

Signed-off-by: Ondra Machacek <[email protected]>
@mnecas
Copy link
Member

mnecas commented Nov 28, 2024

Please link some issues showing why/where you need it.
It does not need to be issue directly on Forklift but could be from your project.

@machacekondra
Copy link
Contributor Author

As part of ticket: https://issues.redhat.com/browse/ECOPROJECT-2376
We need to have unique identification of the Vcenter.
So far @tupyy solved it inside our code here: kubev2v/migration-planner#81

We need it so we can distinguish where the generated OVA is connected to so we don't gather it twice for same Vcenter, so Vcenter UUID is unique identification for us.

Copy link
Member

@mnecas mnecas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 15.65%. Comparing base (840fa31) to head (8a08a19).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...controller/provider/container/vsphere/collector.go 0.00% 3 Missing ⚠️
pkg/controller/provider/web/vsphere/provider.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1224      +/-   ##
==========================================
- Coverage   15.65%   15.65%   -0.01%     
==========================================
  Files         112      112              
  Lines       23075    23077       +2     
==========================================
  Hits         3612     3612              
- Misses      19178    19180       +2     
  Partials      285      285              
Flag Coverage Δ
unittests 15.65% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mnecas mnecas merged commit 4c1195e into kubev2v:main Nov 28, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants