-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance OVA provider help text fields #848
Enhance OVA provider help text fields #848
Conversation
cc:// @RichardHoch @anarnold97 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
help texts should be one line, we have a different issue for multi line help texts #
I wondered about that as well and wanted your feedback. I will try one line since a tooltip looks overheaded here. |
You should not have a text that can be split up, if it can be split to two lines it's too long. we have a different task, for longer help hints #541 |
Enhance and rephrase the help text fields and validations for following OVA dialogs: 1. Create OVA provider, 2. OCP details - URL title icon help text Changes include supporting formatted help text. Signed-off-by: Sharon Gratch <[email protected]>
ea0d99a
to
7974686
Compare
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
URL of the NFS file share that serves the OVA.{'<br><br>'} | ||
Ensure the URL is in the following format: {'<strong>'}nfs_server:/nfs_path | ||
{'</strong>'}, where:{'<br>'} | ||
{'<strong>'}nfs_server:{'</strong>'} An IP or hostname of the server where the share |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe "the"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RichardHoch Do you mean replacing "An IP or hostname of.."
with: "The IP or hostname of..." ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sgratch Yes, that is my suggestion if in Hebrew you would say "ה" If not, then it's fine as is.
@RichardHoch Line 226 in 57b1085
|
Yes, please. |
@RichardHoch This is not part of this PR but will be fixed if needed. What are your comments for this text? |
@sgratch "Create Providers by using the form or manually entering YAML or JSON definitions. Provider CRs store attributes that enable MTV to connect to and interact with the source and target providers." |
Based on doc team's review: kubev2v#848 (comment) kubev2v#848 (comment) Signed-off-by: Sharon Gratch <[email protected]>
Based on doc team's review: kubev2v#848 (comment) Signed-off-by: Sharon Gratch <[email protected]>
Reference: #646
Enhance and rephrase the help text fields and validations for following OVA dialogs:
Changes include supporting formatted help text.
Screenshots