Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render VM name as resource link for local cluster #767

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Render VM name as resource link for local cluster #767

merged 2 commits into from
Nov 28, 2023

Conversation

rszwajko
Copy link
Contributor

@rszwajko rszwajko commented Oct 30, 2023 •
edited
Loading

VMs on local cluster:
Screenshot from 2023-10-30 21-31-16

Other VMs:
Screenshot from 2023-10-30 21-14-44

@rszwajko rszwajko requested review from yaacov, sjd78 and sgratch October 30, 2023 20:35
@yaacov
Copy link
Member

yaacov commented Oct 31, 2023

Ref: #768

@yaacov yaacov added the enhancement Categorizes issue or PR as related to a new feature. label Oct 31, 2023
@yaacov yaacov added this to the 2.6.0 milestone Oct 31, 2023
@rszwajko rszwajko marked this pull request as ready for review October 31, 2023 16:47
yaacov
yaacov approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@yaacov yaacov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p.s.
isProviderLocalTarget functionality is used in some places in the code as inline code, we should sync all use cases to use this method

@yaacov
Copy link
Member

yaacov commented Nov 28, 2023

@rszwajko this PR is failing on cypress, can you rebase on latest main (with the consolse authentication fix), and try again ?

@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@yaacov yaacov merged commit 6bc0dcd into kubev2v:main Nov 28, 2023
8 checks passed
@yaacov yaacov mentioned this pull request Jan 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaacov yaacov yaacov approved these changes

@sjd78 sjd78 Awaiting requested review from sjd78

@sgratch sgratch Awaiting requested review from sgratch

Assignees
No one assigned
Labels
enhancement Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@rszwajko @yaacov