Fix the behaviour of the new project field for Kind installation #1417
Conversation
sgratch
force-pushed
the
fix-new-project-field-for-providers-behaviour-on-kind
branch
2 times, most recently
from
e3ed2dc to
fba00db
Compare
| isList: true, | ||
| }); | ||
|
|
||
| return !projects || !projectsLoaded || projectsLoadError |
There was a problem hiding this comment.
IIRC when using isList prop on on hook above it always return array. Empty or with content. So in this case checking !project don't have any need as array is always truthy
There was a problem hiding this comment.
Correct, fixing to check the array length..
sgratch
force-pushed
the
fix-new-project-field-for-providers-behaviour-on-kind
branch
from
fba00db to
4223f3c
Compare
Reference: kubev2v#1409 (comment) - comment num 1. - Enable the ProjectNameSelect component to run on Kind (non OCP) installaiton, the same as supported for the console namespaces menu. -Fix the namespace default value for upstream. Signed-off-by: Sharon Gratch <[email protected]>
sgratch
force-pushed
the
fix-new-project-field-for-providers-behaviour-on-kind
branch
from
4223f3c to
3dcb635
Compare
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1417 +/- ##
==========================================
- Coverage 36.81% 36.21% -0.60%
==========================================
Files 158 159 +1
Lines 2548 2579 +31
Branches 599 589 -10
==========================================
- Hits 938 934 -4
- Misses 1428 1643 +215
+ Partials 182 2 -180 ☔ View full report in Codecov by Sentry. |
Reference: #1409 (comment) - comment (1).
ProjectNameSelectcomponent to run on Kind (non OCP) installation, the same as supported for the console namespaces menu.konveyor-forkliftfor u/s,openshift-mtvfor d/s )Screenshots for kind installation, current is set to
all-namespacesBefore
After