Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude the 'Edit Provider Credentials' dropdown menu item for OVA provider #1407

Conversation

sgratch
Copy link
Collaborator

@sgratch sgratch commented Dec 10, 2024

Reference: https://issues.redhat.com/browse/MTV-1766

Since editing the OVA provider credentials is not supported, exclude this option from the providers drop-down menu items.

Screenshot

Screenshot from 2024-12-10 20-27-41

Reference: https://issues.redhat.com/browse/MTV-1766

Since editing the OVA provider cresentials is not supported, exclude
this option from the providers dropdown menu items.

Signed-off-by: Sharon Gratch <[email protected]>
@sgratch sgratch requested review from yaacov and metalice December 10, 2024 18:28
@sgratch sgratch added the bug Categorizes issue or PR as related to a bug. label Dec 10, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.21%. Comparing base (13484d0) to head (ea4f80d).
Report is 148 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1407      +/-   ##
==========================================
- Coverage   36.81%   36.21%   -0.60%     
==========================================
  Files         158      159       +1     
  Lines        2548     2579      +31     
  Branches      599      603       +4     
==========================================
- Hits          938      934       -4     
- Misses       1428     1463      +35     
  Partials      182      182              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metalice metalice merged commit 4000d26 into kubev2v:main Dec 11, 2024
11 checks passed
@sgratch sgratch deleted the exclude-EditCredentials-from-provider-dropdown-for-ova branch December 11, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants