Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MTV-1690: Plan wizard - Step 2 - Update mappings section #1391

Merged
merged 1 commit into from
Nov 24, 2024

Conversation

jschuler
Copy link
Contributor

Reference: https://issues.redhat.com/browse/MTV-1690

Update the mappings section in step 2 so that they are their own Network and storage sections.
Also add headings to the lists so that it is more clear.

Before After
Screenshot 2024-11-22 at 2 03 24 PM Screenshot 2024-11-22 at 2 14 19 PM
Screenshot 2024-11-22 at 2 03 39 PM Screenshot 2024-11-22 at 2 14 43 PM

@@ -21,8 +43,17 @@

.forklift--create-vm-migration-plan--section-header {
margin-bottom: 0;
justify-content: start;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So that the NM and SM labels in the headers appear next to the text and are vertically centered

</SelectGroup>
</Select>
<Form>
<FormGroup label={t('Source')}>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrapped existing Selects in FormGroup so that they can be given labels for small screen widths

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice !

className="forklift--create-vm-migration-plan--section-header"
/>
>
<ResourceLink
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shifted ResourceLink labels into the section headings

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.16%. Comparing base (13484d0) to head (a226f56).
Report is 124 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1391      +/-   ##
==========================================
- Coverage   36.81%   36.16%   -0.65%     
==========================================
  Files         158      158              
  Lines        2548     2577      +29     
  Branches      599      589      -10     
==========================================
- Hits          938      932       -6     
- Misses       1428     1643     +215     
+ Partials      182        2     -180     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Member

@yaacov yaacov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yaacov
Copy link
Member

yaacov commented Nov 24, 2024

/ok-to-test

@yaacov yaacov merged commit 9169367 into kubev2v:main Nov 24, 2024
10 checks passed
@sgratch sgratch added the enhancement Categorizes issue or PR as related to a new feature. label Nov 27, 2024
@sgratch sgratch modified the milestones: 2.8.0, 2.7.6 Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants