-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MTV-1690: Plan wizard - Step 2 - Update mappings section #1391
Conversation
@@ -21,8 +43,17 @@ | |||
|
|||
.forklift--create-vm-migration-plan--section-header { | |||
margin-bottom: 0; | |||
justify-content: start; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So that the NM
and SM
labels in the headers appear next to the text and are vertically centered
</SelectGroup> | ||
</Select> | ||
<Form> | ||
<FormGroup label={t('Source')}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrapped existing Selects in FormGroup so that they can be given labels for small screen widths
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice !
className="forklift--create-vm-migration-plan--section-header" | ||
/> | ||
> | ||
<ResourceLink |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shifted ResourceLink labels into the section headings
Signed-off-by: Joachim Schuler <[email protected]>
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1391 +/- ##
==========================================
- Coverage 36.81% 36.16% -0.65%
==========================================
Files 158 158
Lines 2548 2577 +29
Branches 599 589 -10
==========================================
- Hits 938 932 -6
- Misses 1428 1643 +215
+ Partials 182 2 -180 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/ok-to-test |
Reference: https://issues.redhat.com/browse/MTV-1690
Update the mappings section in step 2 so that they are their own Network and storage sections.
Also add headings to the lists so that it is more clear.