MTV-1504 | Add UI for setting inventory memory limits #1384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are currently knobs that can be used to adjust the memory limit for the `main` container, but not for the `inventory` container. This can cause the inventory container to go into a crash loop on a large deployment. Add the ability to bump the inventory memory limit to avoid this. Fixes: https://issues.redhat.com/browse/MTV-1504 Signed-off-by: Jonathon Jongsma <[email protected]>
|
yaacov
changed the title
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1384 +/- ##
==========================================
- Coverage 36.81% 36.16% -0.65%
==========================================
Files 158 158
Lines 2548 2577 +29
Branches 599 605 +6
==========================================
- Hits 938 932 -6
- Misses 1428 1463 +35
Partials 182 182 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are currently knobs that can be used to adjust the memory limit
for the
maincontainer, but not for theinventorycontainer. Thiscan cause the inventory container to go into a crash loop on a large
deployment. Add the ability to bump the inventory memory limit to avoid
this.
Fixes: https://issues.redhat.com/browse/MTV-1504
--
NOTE: The options chosen here were modeled on the options for the main container
memory limits, but the lower value was shifted up slightly to match the
difference in the default memory limit (800 vs 1000).
Screenshots:
