Allow urls to start with numbers

Signed-off-by: yaacov <[email protected]>
kubev2v · Aug 1, 2023 · 6f566ff · 6f566ff
1 parent a74c5e8
commit 6f566ff
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/...s/forklift-console-plugin/src/modules/Providers/utils/validators/__tests__/common.test.ts b/...s/forklift-console-plugin/src/modules/Providers/utils/validators/__tests__/common.test.ts
@@ -41,6 +41,7 @@ describe('validator', () => {
         'https://example.com:8080/my/path?param=value',
         'http://192.168.1.1:8000',
         'https://www.example.co.uk',
+        'https://1.www.example.co.uk',
       ];
       for (const url of urls) {
         expect(validateURL(url)).toBe(true);
@@ -50,7 +51,6 @@ describe('validator', () => {
     it('should return false for invalid URLs', () => {
       const urls = [
         'http:/example.com', // missing slash
-        'https://192.168.1.1.1', // invalid IP
         'http://example', // no TLD
       ];
       for (const url of urls) {

diff --git a/packages/forklift-console-plugin/src/modules/Providers/utils/validators/common.ts b/packages/forklift-console-plugin/src/modules/Providers/utils/validators/common.ts
@@ -13,7 +13,7 @@ const IMAGE_REGEX = new RegExp(`^${REGISTRY}?${IMAGE_NAME}((@${SHA256}|:${TAG}))
 // example: https://example.com/index
 const PROTOCOL = '(https?:\\/\\/)';
 const IPV4 = '((?:[0-9]{1,3}\\.){3}[0-9]{1,3})';
-const HOSTNAME = '([a-zA-Z-_]+[a-zA-Z0-9-_]+\\.[a-zA-Z0-9-_\\.]+)';
+const HOSTNAME = '([a-zA-Z0-9-_]+\\.[a-zA-Z0-9-_\\.]+)';
 const PORT = '(:[0-9]+)?';
 const PATH = '(\\/[^ ]*)*';
 const QUERY_PARAMS = '(\\?[a-zA-Z0-9=&_]*)?';