support new event version #171
Conversation
|
@junotx @wanjunlei pls help to review |
Gentleelephant
force-pushed
the
new-event-version
branch
from
080938e to
8d3a49c
Compare
cmd/exporter/main.go
Outdated
| masterURL string | ||
| kubeconfig string | ||
| configFile string | ||
| newEventType bool |
There was a problem hiding this comment.
Use eventVersion instead, known values are corev1 and eventsv1
|
|
||
| ns, err := client.CoreV1().Namespaces().Get(context.Background(), "kubesphere-system", metav1.GetOptions{}) | ||
| if err != nil { | ||
| klog.Errorf("get namespace kubesphere-system error: %s", err) |
There was a problem hiding this comment.
The function needs to exit here, otherwise, ns will be nil and the following code will report an error.
| @@ -4,6 +4,10 @@ import ( | |||
| "context" | |||
| "errors" | |||
| "fmt" | |||
| "github.com/kubesphere/kube-events/pkg/util" | |||
|
The ruler should be changed too. |
|
字段都不太一样了，如果要真正完全支持，还要改 vector 配置 和 WhizardTelemetry 平台服务查 OpenSearch 的代码？ |
pkg/exporter/kube_events_exporter.go
Outdated
| @@ -6,6 +6,11 @@ import ( | |||
| "fmt" | |||
| "sync" | |||
|
|
|||
| "github.com/kubesphere/kube-events/pkg/util" | |||
| v1 "k8s.io/api/events/v1" | |||
There was a problem hiding this comment.
| v1 "k8s.io/api/events/v1" | |
| eventsv1 "k8s.io/api/events/v1" |
Gentleelephant
force-pushed
the
new-event-version
branch
from
7d6f812 to
573ba1e
Compare
完全适配，以后肯定得改 |
|
the arg name is still |
Gentleelephant
force-pushed
the
new-event-version
branch
from
573ba1e to
6e86d89
Compare
| setCluster(client) | ||
| c := time.Tick(60 * time.Second) | ||
| for { | ||
| select { |
There was a problem hiding this comment.
成功一次还需要继续 loop 吗
民生银行那个是怎么出错的可以重现吗，他的情况我理解如果第一次没有成功从 annotation获取到 cluster name，retry 到成功就可以了。
会有 cluster 改名的情况吗，很少吧
Gentleelephant
force-pushed
the
new-event-version
branch
from
6e86d89 to
04909f3
Compare
newEventType参数为true开启，默认为false旧版事件输出
{"metadata":{"name":"ks-apiserver-7b94f9bd6f-vbtfp.17e9145e250bdcef","namespace":"kubesphere-system","uid":"40fa04c5-66f2-4c6e-8201-3b13b17dbc35","resourceVersion":"8460007","creationTimestamp":"2024-08-06T07:52:07Z"},"involvedObject":{"kind":"Pod","namespace":"kubesphere-system","name":"ks-apiserver-7b94f9bd6f-vbtfp","uid":"0ec6bbc8-9ba1-42f9-87b0-0dcfa99c0c57","apiVersion":"v1","resourceVersion":"8305839"},"reason":"FailedScheduling","message":"0/1 nodes are available: 1 node(s) didn't match pod anti-affinity rules.","source":{},"firstTimestamp":null,"lastTimestamp":null,"type":"Warning","eventTime":"2024-08-06T07:52:07.026936Z","series":{"count":1013,"lastObservedTime":"2024-08-07T01:32:29.267628Z"},"action":"Scheduling","reportingComponent":"default-scheduler","reportingInstance":"default-scheduler-i-bhbpy0xx","cluster":"host"}新版事件输出
{"metadata":{"name":"ks-apiserver-7b94f9bd6f-vbtfp.17e9145e250bdcef","namespace":"kubesphere-system","uid":"40fa04c5-66f2-4c6e-8201-3b13b17dbc35","resourceVersion":"8460007","creationTimestamp":"2024-08-06T07:52:07Z"},"eventTime":"2024-08-06T07:52:07.026936Z","series":{"count":1013,"lastObservedTime":"2024-08-07T01:32:29.267628Z"},"reportingController":"default-scheduler","reportingInstance":"default-scheduler-i-bhbpy0xx","action":"Scheduling","reason":"FailedScheduling","regarding":{"kind":"Pod","namespace":"kubesphere-system","name":"ks-apiserver-7b94f9bd6f-vbtfp","uid":"0ec6bbc8-9ba1-42f9-87b0-0dcfa99c0c57","apiVersion":"v1","resourceVersion":"8305839"},"note":"0/1 nodes are available: 1 node(s) didn't match pod anti-affinity rules.","type":"Warning","deprecatedSource":{},"deprecatedFirstTimestamp":null,"deprecatedLastTimestamp":null,"cluster":"host"}